Merged
Conversation
TomasVotruba
force-pushed
the
callable-type
branch
2 times, most recently
from
1d96f0b to
e09c2ce
Compare
TomasVotruba
force-pushed
the
callable-type
branch
from
e09c2ce to
3dd1e7c
Compare
Contributor
|
Looks like missing mixed is a problem... phpstan/phpstan#3008 |
Contributor
|
@TomasVotruba did you see that ^^ ? |
Member
Author
|
tl;dr; I don't have time for this part anymore, but I can guide you in the possible fix |
Contributor
|
@TomasVotruba waiting for hints :) |
Member
Author
|
You need to detect format of original content in: Then modify __toString() method to reflect it |
TomasVotruba
added a commit
that referenced
this pull request
Sep 1, 2022
rectorphp/rector-src@3c07468 [DX] Localize few PackageBuilder classes (#2884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers #2881
@snapshotpl This is the best I could do. The return
mixedis removed, as its default value and it would polute all the callables by default.