Skip to content

Fix already constant #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Feb 19, 2020
Merged

Fix already constant #2885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f63457
Fix already constant
TomasVotruba Feb 19, 2020
9da97ed
update alias
TomasVotruba Feb 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@
},
"extra": {
"branch-alias": {
"dev-master": "0.6-dev"
"dev-master": "0.8-dev"
}
}
}
7 changes: 6 additions & 1 deletion ...s/solid/src/Rector/ClassMethod/ChangeReadOnlyVariableWithDefaultValueToConstantRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,13 @@ private function refactorClassMethod(ClassMethod $classMethod, Class_ $class, ar
foreach ($readOnlyVariableAssigns as $readOnlyVariableAssign) {
$this->removeNode($readOnlyVariableAssign);

/** @var Variable $variable */
/** @var Variable|ClassConstFetch $variable */
$variable = $readOnlyVariableAssign->var;
// already overriden
if (! $variable instanceof Variable) {
continue;
}

$classConst = $this->createClassConst($variable, $readOnlyVariableAssign->expr);

// replace $variable usage in the code with constant
Expand Down