Merged
Conversation
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
rector-solid
branch
2 times, most recently
from
7ecea8e to
3d94c5f
Compare
TomasVotruba
force-pushed
the
rector-solid
branch
from
131cb56 to
3266409
Compare
TomasVotruba
force-pushed
the
rector-solid
branch
from
74e783b to
cef9003
Compare
TomasVotruba
force-pushed
the
rector-solid
branch
from
2fd7bd2 to
6ba1d21
Compare
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2908
Todo
$tagValueNode::SHORT_NAMEto use->getShortName()method to make design less magical and required by interface contract