[Sensiolabs] Add @Template annotation to render() Rector

[TomasVotruba]

Closes #287

Closes #295

Resources

• https://github.com/sensiolabs/SensioFrameworkExtraBundle/blob/master/Templating/TemplateGuesser.php

• https://github.com/sensiolabs/SensioFrameworkExtraBundle/blob/master/Tests/Templating/TemplateGuesserTest.php

• Docs: https://symfony.com/doc/4.0/bundles/SensioFrameworkExtraBundle/annotations/view.html

[TomasVotruba]

@mssimi Could I ask you for a review?
And also providing more use cases from your real practise?

I think we'll have to reimplement TemplateGuesser in framework agnostics way here

[mssimi]

I will test it on my code.

[mssimi]

I am unable to run rector of this branch. With dev-master I have no problem.

Class 'Symplify\PackageBuilder\Console\Style\SymfonyStyleFactory' not found in /home/mssimi/www/xxx/vendor-bin/rector/vendor/rector/rector/bin/rector:47

I actually added some extra commits here #292 , but dont know how to add them to this pull request

[TomasVotruba]

I am unable to run rector of this branch. With dev-master I have no problem.

I've just rebased on master, there was one autoloading fix

[TomasVotruba]

@mssimi I've added framework agnostic TemplateGuesser to cover your cases. Check it 👍

[mssimi]

It is no good yet:)

return $this->redirectToRoute('_forgotten'); // before
return $this->render('AppBundle:User:forgotten.html.twig'); // after

// before
return $this->render('@App/User/changePassword.html.twig', array(
     'form' => $form->createView()
));
//after
return $this->render('AppBundle:User:passwordChange.html.twig');

It should touch only return array statements. For use cases where no other return statement is it seems to work well.

[mssimi]

I checked it quickly and still found some problems, but we r getting there:). I will add more commits later today.

@mssimi I though about adding yml and other files - but it's too complicated and require lot of extra work which would influence the quality of PHP part, so I've removed it.

Damn most of my ideas require fixing yml and twig:)

Edit:

@TomasVotruba I added more tests and fixed them in my fork, but after looking more into it I found out, we will have to improve template guesser to match this one. We may have to improve bundle name guessing as well as guessing if Controller is even a bundle, since template annotation works even for non-bundle controller, where template name is generated differently.

[TomasVotruba]

@mssimi Could you send PR with failing test cases like before?

[mssimi]

@TomasVotruba I tried to re-implement it myself, there is bug in phpdoc regeneration, it generates unneeded space, can't find it. Are you available on hangout to discuss it?

[TomasVotruba]

Sure: tomas.vot@gmail.com

[TomasVotruba]

Ha, a bug :)

[TomasVotruba]

@mssimi Could you review please?

I've added support for TemplateGuesser for v5 and v3

[mssimi]

@TomasVotruba I already refactored one project with that, everything seems fine:)

[TomasVotruba]

I've added @Route ( space solution as well.

Thanks for fast cooperation 👍