[JMS] Add RemoveJmsInjectParamsAnnotationRector and RemoveJmsServiceAnnotationRector#2914
Merged
TomasVotruba merged 1 commit intomasterfrom Feb 23, 2020
Merged
[JMS] Add RemoveJmsInjectParamsAnnotationRector and RemoveJmsServiceAnnotationRector#2914TomasVotruba merged 1 commit intomasterfrom
TomasVotruba merged 1 commit intomasterfrom
Conversation
TomasVotruba
force-pushed
the
fix-remove-di
branch
from
71f5a43 to
8347a4c
Compare
stloyd
reviewed
Feb 24, 2020
| * "ipService" = @DI\Inject("app.util.service.ip") | ||
| * }) | ||
| */ | ||
| public function __construct() { |
Contributor
There was a problem hiding this comment.
Shouldn't this be (maybe not before, but after for sure if you use i.e. Symfony):
public function __construct($subscribeService, $ipService)
{
}
Member
Author
There was a problem hiding this comment.
It's only about doc blocks. The code is minimal possible, see the original issue
TomasVotruba
added a commit
that referenced
this pull request
Sep 6, 2022
rectorphp/rector-src@e5d9275 [Doctrine] Handle Partial removal annotation has annotation below on RemoveRedundantDefaultPropertyAnnotationValuesRector (#2914)
TomasVotruba
added a commit
that referenced
this pull request
Sep 6, 2022
rectorphp/rector-src@e5d9275 [Doctrine] Handle Partial removal annotation has annotation below on RemoveRedundantDefaultPropertyAnnotationValuesRector (#2914)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2864