Skip to content

AddSeeTestAnnotationRectorTest: add broken test for simple comment.#2951

Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom
gnutix:AddSeeTestAnnotationRectorTest/add-broken-test-simple-comment
Feb 29, 2020
Merged

AddSeeTestAnnotationRectorTest: add broken test for simple comment.#2951
TomasVotruba merged 1 commit intorectorphp:masterfrom
gnutix:AddSeeTestAnnotationRectorTest/add-broken-test-simple-comment

Conversation

@gnutix
Copy link
Copy Markdown
Contributor

@gnutix gnutix commented Feb 28, 2020

I was not able to reproduce in the demo however (where it adds the @see annotation even on the simple comment...) https://getrector.org/demo/9890b876-ff9e-4bd4-bff1-ad1598d41f42#result

In local I get an error block like :

 [ERROR] Could not process "File.php" file by                           
         "Rector\PHPUnit\Rector\Class_\AddSeeTestAnnotationRector", due to:                                             
         "Call to a member function getTagsByName() on null".                                                                                                                                                                                 

@TomasVotruba TomasVotruba merged commit 1452472 into rectorphp:master Feb 29, 2020
@TomasVotruba TomasVotruba deleted the AddSeeTestAnnotationRectorTest/add-broken-test-simple-comment branch February 29, 2020 00:21
@TomasVotruba TomasVotruba mentioned this pull request Feb 29, 2020
TomasVotruba added a commit that referenced this pull request Sep 23, 2022
rectorphp/rector-src@df36e38 [Naming] Add TwigEnvironment special name to RenameParamToMatchTypeRector to keep the context (#2951)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants