ReturnTypeDeclarationRector: add broken test on array indexes (?)#2952
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Feb 29, 2020
Conversation
gnutix
changed the title
Member
|
Nice test! 👍 |
TomasVotruba
deleted the
ReturnTypeDeclarationRector/add-broken-test-array-index
branch
TomasVotruba
added a commit
that referenced
this pull request
Sep 24, 2022
rectorphp/rector-src@2015f46 [AutoImport] Add support for auto import in alias same last name (#2952)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure exactly what's happening here ; might have to do with the fact that we access an array index using
[0]?But I'm pretty sure it shouldn't replace
): \stdClassby): arrayas it will break the code (PS: in my real code it's not \stdClass but some domain object).