Skip to content

AssertTrueFalseInternalTypeToSpecificMethodRector: add broken test method call#2956

Merged
TomasVotruba merged 2 commits intorectorphp:masterfrom
gnutix:AssertTrueFalseInternalTypeToSpecificMethodRector/add-broken-test-method-call
Feb 29, 2020
Merged

AssertTrueFalseInternalTypeToSpecificMethodRector: add broken test method call#2956
TomasVotruba merged 2 commits intorectorphp:masterfrom
gnutix:AssertTrueFalseInternalTypeToSpecificMethodRector/add-broken-test-method-call

Conversation

@gnutix
Copy link
Copy Markdown
Contributor

@gnutix gnutix commented Feb 28, 2020

Might be related to #2954 and #2955. They all come from Rector\NodeNameResolver\NodeNameResolver->getName(). I won't open any more issues like this one for now as to not spam you if it all comes from the same source ; this should give you enough of a sample to work with. ;)

Fails with error :

 [ERROR] Could not process "File.php" file, due to:     
         "Pick more specific node than "PhpParser\Node\Expr\MethodCall"".     

@gnutix gnutix changed the title Assert true false internal type to specific method rector/add broken test method call AssertTrueFalseInternalTypeToSpecificMethodRector: add broken test method call Feb 28, 2020
@TomasVotruba
Copy link
Copy Markdown
Member

If you run it with --debug option, it will show you where the getName() is called from.

Instead of getName($node), there should be something like getName($node->name)

@TomasVotruba TomasVotruba deleted the AssertTrueFalseInternalTypeToSpecificMethodRector/add-broken-test-method-call branch February 29, 2020 00:23
@TomasVotruba TomasVotruba restored the AssertTrueFalseInternalTypeToSpecificMethodRector/add-broken-test-method-call branch February 29, 2020 00:23
@TomasVotruba TomasVotruba reopened this Feb 29, 2020
@TomasVotruba TomasVotruba merged commit 8f3e90b into rectorphp:master Feb 29, 2020
@TomasVotruba TomasVotruba deleted the AssertTrueFalseInternalTypeToSpecificMethodRector/add-broken-test-method-call branch February 29, 2020 00:23
@TomasVotruba
Copy link
Copy Markdown
Member

Miss-click

@TomasVotruba TomasVotruba mentioned this pull request Feb 29, 2020
TomasVotruba added a commit that referenced this pull request Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants