Add failing tests for method annotation#3003
Merged
TomasVotruba merged 4 commits intorectorphp:masterfrom Mar 4, 2020
Merged
Conversation
Member
|
Could you fix conflicts? I can't merge it now |
…ekay/rector into failing-tests-for-method-annotation
Contributor
Author
|
Sorry, got totally confused with the syncing of the repositories. Now it should be fine. |
Member
|
It shows 3000 changed files now :D That happens. I usually delete the work, re-fork it again and apply the changes again. |
Contributor
Author
|
Now I'm even more confused. I can only see 2 file changes (?). |
Member
|
Oh, it showed me 3000 files a while ago. I'll check it |
Merged
TomasVotruba
added a commit
that referenced
this pull request
Oct 19, 2022
rectorphp/rector-src@e4ec1f9 [Php70] Handle crash on First class callable on ThisCallOnStaticMethodToStaticCallRector (#3003)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added two failing tests for the MergeMethodAnnotationToRouteAnnotationRector.
In my opinion it shouldn't change the template annotation and it seems that the method won't be merged if some other annotation stands between the Route and Method annoation.
When the tests will get fixed, this PR will fix issue #2785.
I wasn't able to get this fixed by myself, maybe you could help me?