Skip to content

Commit rector processed changes from CI #3013

Merged
TomasVotruba merged 19 commits intomasterfrom
commit-rector-changes-from-github-actions
Mar 12, 2020
Merged

Commit rector processed changes from CI #3013
TomasVotruba merged 19 commits intomasterfrom
commit-rector-changes-from-github-actions

Conversation

@JanMikes
Copy link
Copy Markdown
Contributor

No description provided.

@JanMikes
Copy link
Copy Markdown
Contributor Author

Work in progress, i just needed to trigger CI and it is only for pull requests now :-)

@JanMikes JanMikes requested a review from TomasVotruba March 11, 2020 21:46
@JanMikes
Copy link
Copy Markdown
Contributor Author

JanMikes commented Mar 11, 2020

There is limitation that it can not run for PRs from forked repositories. It can be done via switching to personal access token, but i am not sure if it does not mean security risk. We can discuss tomorrow what are requested features :-)

One more thing is that workflows are not run again for the automated commit, it can be solved in the same way, by adding personal access token.

@TomasVotruba
Copy link
Copy Markdown
Member

Looks good 👍

Ready to merge for me

run: |
git config --global user.name 'rector-bot'
git config --global user.email 'tomas@getrector.org'
git commit -am "Bot commit"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomasVotruba i would love to improve this commit message, please do you have any suggestions?

Comment thread src/DogFood/DogFoodClass.php
@TomasVotruba TomasVotruba merged commit df67615 into master Mar 12, 2020
@TomasVotruba TomasVotruba deleted the commit-rector-changes-from-github-actions branch March 12, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants