Closed
Conversation
greg0ire
commented
Mar 22, 2020
| } | ||
| source: | ||
| - https://github.com/sebastianbergmann/phpunit/issues/3120 | ||
| set: "phpunit90" |
Contributor
Author
There was a problem hiding this comment.
I will revert the commit that contains this file, it's just here for reference.
Member
There was a problem hiding this comment.
Tip: you can put this into create-rector.yaml file and it won't be commited.
https://github.com/rectorphp/rector/blob/master/.gitignore#L12
That's how I use it
greg0ire
commented
Mar 22, 2020
| return null; | ||
| } | ||
|
|
||
| dump($this->methodCallManipulator->findMethodCallNamesOnVariable($parentNode->var)); |
Contributor
Author
There was a problem hiding this comment.
I would expect to get all method calls made on $stub and $mock here.
Comment on lines
+61
to
+63
| $stub = $this->createStub(\Exception::class); | ||
| $stub->method('getMessage') | ||
| ->willReturn('a message'); |
greg0ire
force-pushed
the
create-mock-to-create-stub
branch
from
aaba762 to
9728589
Compare
Member
|
Replaced by #3042 I had to rework chain method caller resolution, as it was not reliable enough. |
This was referenced Apr 11, 2020
TomasVotruba
added a commit
that referenced
this pull request
Nov 10, 2022
rectorphp/rector-src@8ede862 Update phpstan message (#3042)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.