Fix assert choice tag value node with class constant reference

packages/better-php-doc-parser/src/PhpDocNode/Symfony/Validator/Constraints/AssertChoiceTagValueNode.php

@@ -4,6 +4,7 @@
 
 namespace Rector\BetterPhpDocParser\PhpDocNode\Symfony\Validator\Constraints;
 
+use Nette\Utils\Strings;
 use Rector\BetterPhpDocParser\Contract\PhpDocNode\ShortNameAwareTagInterface;
 use Rector\BetterPhpDocParser\Contract\PhpDocNode\TypeAwareTagValueNodeInterface;
 use Rector\Symfony\PhpDocParser\Ast\PhpDoc\AbstractConstraintTagValueNode;
@@ -25,6 +26,16 @@ final class AssertChoiceTagValueNode extends AbstractConstraintTagValueNode impl
      */
     private $choices;
 
+    /**
+     * @var string|null
+     */
+    private $originalChoiceContent;
+
+    /**
+     * @var bool
+     */
+    private $hasChoiceKeywordExplicit = false;
+
     /**
      * @param mixed[]|string|null $callback
      */
@@ -34,6 +45,12 @@ public function __construct($callback, ?bool $strict, string $annotationContent,
         $this->strict = $strict;
         $this->resolveOriginalContentSpacingAndOrder($annotationContent);
         $this->choices = $choices;
+
+        // is default key
+        $this->hasChoiceKeywordExplicit = (bool) Strings::match($annotationContent, '#choices=#');
+
+        // hotfix for https://github.com/rectorphp/rector/issues/3044, the constant reference is actually parsed to values
+        $this->originalChoiceContent = $this->resolveOriginalChoiceContent($annotationContent);
     }
 
     public function __toString(): string
@@ -47,7 +64,7 @@ public function __toString(): string
                 $contentItems['callback'] = sprintf('callback="%s"', $this->callback);
             }
         } elseif ($this->choices) {
-            $contentItems[] = $this->printArrayItem($this->choices);
+            $contentItems[] = $this->createChoices();
         }
 
         if ($this->strict !== null) {
@@ -71,4 +88,41 @@ public function getShortName(): string
     {
         return '@Assert\Choice';
     }
+
+    private function isClassConstantReference(?string $originalChoiceContent): bool
+    {
+        if ($originalChoiceContent === null) {
+            return false;
+        }
+
+        return Strings::contains($originalChoiceContent, '::');
+    }
+
+    private function createOriginalChoiceContent()
+    {
+        $content = '';
+        if ($this->hasChoiceKeywordExplicit) {
+            $content = 'choices=';
+        }
+
+        return $content . $this->originalChoiceContent;
+    }
+
+    private function resolveOriginalChoiceContent(string $annotationContent): ?string
+    {
+        $matches = Strings::match($annotationContent, '#(\(choices=|\()(?<choice_content>.*?)(\)|,)#ms');
+
+        return $matches['choice_content'] ?? null;
+    }
+
+    private function createChoices(): string
+    {
+        if ($this->isClassConstantReference($this->originalChoiceContent)) {
+            return $this->createOriginalChoiceContent();
+        }
+
+        assert(is_array($this->choices));
+
+        return $this->printArrayItem($this->choices);
+    }
 }