[PHP 7.4] Improve TypedPropertyRector for Doctrine collection#3056
Merged
TomasVotruba merged 1 commit intomasterfrom Mar 24, 2020
Merged
[PHP 7.4] Improve TypedPropertyRector for Doctrine collection#3056TomasVotruba merged 1 commit intomasterfrom
TomasVotruba merged 1 commit intomasterfrom
Conversation
7dd4b4d to
aa9588f
Compare
TomasVotruba
added a commit
that referenced
this pull request
Nov 12, 2022
rectorphp/rector-src@2be958b [Core] Fix resolve scope handling when parent Node just re-printed (#3056)
TomasVotruba
added a commit
that referenced
this pull request
Nov 12, 2022
rectorphp/rector-src@2be958b [Core] Fix resolve scope handling when parent Node just re-printed (#3056)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Doctrine Collections were Skipped
Now The Collection Type is Used and Annotation Kept, to add more info
<?php namespace Rector\Php74\Tests\Rector\Property\TypedPropertyRector\Fixture; use Doctrine\Common\Collections\Collection; use Doctrine\ORM\Mapping as ORM; use Pehapkari\Training\Entity\TrainingTerm; /** * @ORM\Entity */ class DoctrineCollection { /** * @ORM\OneToMany(targetEntity="Pehapkari\Training\Entity\TrainingTerm", mappedBy="training") * @var TrainingTerm[]&Collection */ - private $trainingTerms; + private Collection $trainingTerms; }