[DeadCode] Add empty() + count($values) > 0 checks to RemoveUnusedNonEmptyArrayBeforeForeachRector#3070
Merged
TomasVotruba merged 3 commits intomasterfrom Mar 26, 2020
Merged
[DeadCode] Add empty() + count($values) > 0 checks to RemoveUnusedNonEmptyArrayBeforeForeachRector#3070TomasVotruba merged 3 commits intomasterfrom
TomasVotruba merged 3 commits intomasterfrom
Conversation
TomasVotruba
force-pushed
the
fix-foreach
branch
from
9ffefaa to
0fe761f
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
fix-foreach
branch
from
a6d4590 to
6a8aa9b
Compare
Member
Author
|
@afilina Any more samples from your favorite legacy projects that we should check here? |
Contributor
|
@TomasVotruba I'll append examples should I stumble upon something new. |
TomasVotruba
added a commit
that referenced
this pull request
Nov 16, 2022
rectorphp/rector-src@8ac960d fix(UpdateFileNameByClassNameFileSystemRector): compare shortClass Wi… (#3070)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #3066