Skip to content

move ci validation scripts to objectivy ProjectValidator package#3097

Merged
TomasVotruba merged 6 commits intomasterfrom
parallel-sets
Mar 29, 2020
Merged

move ci validation scripts to objectivy ProjectValidator package#3097
TomasVotruba merged 6 commits intomasterfrom
parallel-sets

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

Follow up to #3094

@TomasVotruba TomasVotruba changed the title Parallel sets move run_all_sets to ValidateSetsCommand Mar 29, 2020
@TomasVotruba TomasVotruba force-pushed the parallel-sets branch 5 times, most recently from 20b91bb to fc3ffd4 Compare March 29, 2020 13:34
@TomasVotruba
Copy link
Copy Markdown
Member Author

cc @paslandau

@TomasVotruba TomasVotruba force-pushed the parallel-sets branch 5 times, most recently from 4e111ce to 4bbf185 Compare March 29, 2020 14:50
@TomasVotruba TomasVotruba changed the title move run_all_sets to ValidateSetsCommand move ci validation scripts to objectivy ProjectValidator package Mar 29, 2020
@TomasVotruba TomasVotruba merged commit 4ce0ab2 into master Mar 29, 2020
@TomasVotruba TomasVotruba deleted the parallel-sets branch March 29, 2020 15:01
@TomasVotruba
Copy link
Copy Markdown
Member Author

TomasVotruba commented Mar 29, 2020

@paslandau There you go!

I took more time than I expected. I got lost in & references a bit.
Objects now look much better than spaghetti we used before :)

Could you check it?

Comment thread utils/project-validator/src/Process/ParallelTaskRunner.php
Comment thread utils/project-validator/src/Command/ValidateSetsCommand.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants