Add DoctrineAnnotationParserSyncer to prevent doctrine/annotation constant by-value override#3134
Merged
TomasVotruba merged 3 commits intomasterfrom Apr 4, 2020
Merged
Conversation
TomasVotruba
force-pushed
the
fix-constant-parsin
branch
2 times, most recently
from
d3e4899 to
9e4380b
Compare
Member
Author
How to test? This must passvendor/bin/phpunit packages/better-php-doc-parser/tests/PhpDocParser/SymfonyValidation/AssertTypeTagValueNodeTest.php |
TomasVotruba
force-pushed
the
fix-constant-parsin
branch
6 times, most recently
from
8dccc3f to
e0d2bd3
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
fix-constant-parsin
branch
8 times, most recently
from
1b90fd5 to
9b6121d
Compare
Member
Author
|
@enumag It's done, check it + review if you like |
TomasVotruba
commented
Apr 4, 2020
| { | ||
| return __DIR__ . '/../../../../packages/doctrine-annotation-generated/src/ConstantPreservingAnnotationReader.php'; | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
@enumag This is one of 2 files re-generated from vendor to local namespace changes and fixes.
TomasVotruba
force-pushed
the
fix-constant-parsin
branch
from
1c0cab0 to
a651afc
Compare
TomasVotruba
force-pushed
the
fix-constant-parsin
branch
2 times, most recently
from
27c6f22 to
2385def
Compare
TomasVotruba
force-pushed
the
fix-constant-parsin
branch
from
87a1c61 to
6291b39
Compare
TomasVotruba
added a commit
that referenced
this pull request
Dec 1, 2022
rectorphp/rector-src@39f43c0 Use Symfony ~6.1.x to avoid crash on update vendor-patch (#3134)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3119