fix sniff public

rules/privatization/src/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector.php

@@ -124,7 +124,6 @@ public function refactor(Node $node): ?Node
     private function shouldSkip(Property $property): bool
     {
         $classNode = $property->getAttribute(AttributeKey::CLASS_NODE);
-
         if ($this->shouldSkipClass($classNode)) {
             return true;
         }
@@ -178,6 +177,10 @@ private function shouldSkipClass(?ClassLike $classLike): bool
             return true;
         }
 
-        return $this->isObjectType($classLike, TestCase::class);
+        if ($this->isObjectType($classLike, TestCase::class)) {
+            return true;
+        }
+
+        return $this->isObjectType($classLike, 'PHP_CodeSniffer\Sniffs\Sniff');
     }
 }

rules/privatization/tests/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/skip_abstract.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalOnlyMethodRector\Fixture;
+namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalPropertyToPrivatePropertyRector\Fixture;
 
 abstract class SkipAbstract
 {

rules/privatization/tests/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/skip_anonymous_class.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalOnlyMethodRector\Fixture;
+namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalPropertyToPrivatePropertyRector\Fixture;
 
 use PhpParser\NodeTraverser;
 

rules/privatization/tests/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/skip_child_property_usage.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalOnlyMethodRector\Fixture;
+namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalPropertyToPrivatePropertyRector\Fixture;
 
 final class SkipChildPropertyUsage extends AbstractWithTearDown
 {

rules/privatization/tests/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/skip_class_extended.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalOnlyMethodRector\Fixture;
+namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalPropertyToPrivatePropertyRector\Fixture;
 
 class SkipClassExtended extends AbstractParentClass
 {

rules/privatization/tests/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/skip_external_fetch.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalOnlyMethodRector\Fixture;
+namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalPropertyToPrivatePropertyRector\Fixture;
 
 class SkipExternalFetch
 {

rules/privatization/tests/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/skip_interface_implemented.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalOnlyMethodRector\Fixture;
+namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalPropertyToPrivatePropertyRector\Fixture;
 
 class SkipInterfaceImplemented
 {

rules/privatization/tests/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/skip_parent_class_protected.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalOnlyMethodRector\Fixture;
+namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalPropertyToPrivatePropertyRector\Fixture;
 
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;

rules/privatization/tests/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/skip_sniff.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalPropertyToPrivatePropertyRector\Fixture;
+
+use PHP_CodeSniffer\Files\File;
+use PHP_CodeSniffer\Sniffs\Sniff;
+
+final class SkipSniff implements Sniff
+{
+    public $sniffConfigProperty;
+
+    public function shouldSkip(string $methodName, string $className): bool
+    {
+        // not really a setter, but usually test "setup" method
+        if ($methodName === 'setUp') {
+            return true;
+        }
+
+        foreach ($this->sniffConfigProperty as $allowedClass) {
+            if (fnmatch($allowedClass, $className, FNM_NOESCAPE)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    public function register()
+    {
+        // TODO: Implement register() method.
+    }
+
+    public function process(File $phpcsFile, $stackPtr)
+    {
+        // TODO: Implement process() method.
+    }
+}

rules/privatization/tests/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/skip_trait.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalOnlyMethodRector\Fixture;
+namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalPropertyToPrivatePropertyRector\Fixture;
 
 trait SkipTrait
 {

rules/privatization/tests/Rector/Property/PrivatizeLocalPropertyToPrivatePropertyRector/Fixture/skip_used_in_trait.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalOnlyMethodRector\Fixture;
+namespace Rector\Privatization\Tests\Rector\Property\PrivatizeLocalPropertyToPrivatePropertyRector\Fixture;
 
 class SkipUsedInTrait
 {

rules/solid/src/Rector/Property/ChangeReadOnlyPropertyWithDefaultValueToConstantRector.php

@@ -99,7 +99,7 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        if (count($node->props) !== 1) {
+        if ($this->shouldSkip($node)) {
             return null;
         }
 
@@ -185,4 +185,18 @@ private function isLocalPropertyFetch(Node $node): bool
 
         return false;
     }
+
+    private function shouldSkip(Property $property): bool
+    {
+        if (count($property->props) !== 1) {
+            return true;
+        }
+
+        $class = $property->getAttribute(AttributeKey::CLASS_NODE);
+        if (! $class instanceof Class_) {
+            return false;
+        }
+
+        return $this->isObjectType($class, 'PHP_CodeSniffer\Sniffs\Sniff');
+    }
 }

rules/solid/tests/Rector/Property/ChangeReadOnlyPropertyWithDefaultValueToConstantRector/Fixture/skip_sniff.php.inc

@@ -0,0 +1,32 @@
+<?php
+
+namespace Rector\SOLID\Tests\Rector\Property\ChangeReadOnlyPropertyWithDefaultValueToConstantRector\Fixture;
+
+use PHP_CodeSniffer\Files\File;
+use PHP_CodeSniffer\Sniffs\Sniff;
+
+final class SkipSniff implements Sniff
+{
+    /**
+     * @var string[]
+     */
+    private $magicMethods = [
+    ];
+
+    public function run()
+    {
+        foreach ($this->magicMethods as $magicMethod) {
+            echo $magicMethod;
+        }
+    }
+
+    public function register()
+    {
+        // TODO: Implement register() method.
+    }
+
+    public function process(File $phpcsFile, $stackPtr)
+    {
+        // TODO: Implement process() method.
+    }
+}

stubs/PHP_CodeSniffer/Sniffs/Sniff.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PHP_CodeSniffer\Sniffs;
+
+if (interface_exists('PHP_CodeSniffer\Sniffs\Sniff')) {
+    return;
+}
+
+interface Sniff
+{
+
+}