Skip to content

Test with Drupal-Rector project to prevent BC breaks early on#3255

Closed
shaal wants to merge 6 commits intorectorphp:masterfrom
shaal:test-with-drupal
Closed

Test with Drupal-Rector project to prevent BC breaks early on#3255
shaal wants to merge 6 commits intorectorphp:masterfrom
shaal:test-with-drupal

Conversation

@shaal
Copy link
Copy Markdown
Contributor

@shaal shaal commented Apr 25, 2020

This is similar to a previous PR - #3187, but for some reason the Drupal Rector test was removed later on.

Today I found out that rector-prefixed v0.7.19 is breaking Drupal Rector.
This PR has the same test from the previous PR + 2 temporary tests that show v0.7.18 is working well, but v0.7.19 breaks.

@shaal
Copy link
Copy Markdown
Contributor Author

shaal commented Apr 25, 2020

This is the Drupal Rector test like in the previous PR (currently fails because of rector-prefix v.0.7.19:
https://github.com/rectorphp/rector/pull/3255/checks?check_run_id=617111805#step:8:6

These are the temporary tests:

  1. Specifically requiring rector-prefix:0.7.18, test is successful:
    https://github.com/rectorphp/rector/pull/3255/checks?check_run_id=617111887#step:6:4

  2. Specifically requiring rector-prefix:0.7.19, test fail:
    https://github.com/rectorphp/rector/pull/3255/checks?check_run_id=617111851#step:6:4

@TomasVotruba
Copy link
Copy Markdown
Member

The prefixed Rector is already tested here: https://github.com/rectorphp/rector-prefixed

I removed the test case, because it's responsibility of the external tool to test it's dependencies.
It's like if Symfony would test all its bundles in Symfony CI.

TomasVotruba added a commit that referenced this pull request Jan 2, 2023
rectorphp/rector-src@cba980b [NodeRemoval] Refactor NodeRemover to always use removeNode() method to ensure Node in NodesToRemoveCollector (#3255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants