Skip to content

[Utils] PHPStan rule improvements#3297

Merged
kodiakhq[bot] merged 4 commits intomasterfrom
see-rule
May 3, 2020
Merged

[Utils] PHPStan rule improvements#3297
kodiakhq[bot] merged 4 commits intomasterfrom
see-rule

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented May 3, 2020

Every Rector should have @see annotation with test case reference, so it's easy to jump in and create a fixture.

Also will be useful in the future for: rectorphp/getrector-com#155


🚫

final class NetteAssertToPHPUnitAssertRector extends AbstractRector

👍

/**
 * @see \Rector\NetteTesterToPHPUnit\Tests\Rector\Class_\NetteTesterClassToPHPUnitClassRector\NetteTesterPHPUnitRectorTest
 */
final class NetteAssertToPHPUnitAssertRector extends AbstractRector

@TomasVotruba TomasVotruba force-pushed the see-rule branch 2 times, most recently from a739af1 to 519d0da Compare May 3, 2020 12:57
@TomasVotruba TomasVotruba changed the title [Utils] PHPStan rule improvemnets [Utils] PHPStan rule improvements May 3, 2020
@TomasVotruba
Copy link
Copy Markdown
Member Author

Thanks for inspiration in sabbelasichon/typo3-rector#1387 to @sabbelasichon

@kodiakhq kodiakhq bot merged commit d89b92f into master May 3, 2020
@kodiakhq kodiakhq bot deleted the see-rule branch May 3, 2020 14:11
TomasVotruba added a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant