Merged
Conversation
Generator was not working
| { | ||
| $robotLoader = new RobotLoader(); | ||
| $robotLoader->addDirectory(__DIR__ . '/../../../../vendor/nikic/php-parser/lib/PhpParser/Node'); | ||
| $robotLoader->addDirectory(__DIR__ . '/../../../../../../nikic/php-parser/lib/PhpParser/Node'); |
Member
There was a problem hiding this comment.
It is working in the main repository.
It's probably because it's installed as dependency. The best would be to support both locations.
Contributor
Author
There was a problem hiding this comment.
Got it @TomasVotruba
Should I add condition here with file_exists() call?
Member
|
Btw, what do you need this for outside the main repository? |
Contributor
Author
|
@TomasVotruba I wanted to create new Rector for my project :) |
Current solution didn't work when I tried to generate rector when it was used as my project dependency. This fix aims to support both solutions - as project dependency or as standalone project.
As per PR
Member
|
Thanks 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Feb 6, 2023
rectorphp/rector-src@5962257 Fix duplicate class take 2 (#3345)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generator was not working