Skip to content

[Nette] Add ContextGetByTypeToConstructorInjectionRector#3399

Merged
TomasVotruba merged 2 commits intomasterfrom
context-to-di
May 22, 2020
Merged

[Nette] Add ContextGetByTypeToConstructorInjectionRector#3399
TomasVotruba merged 2 commits intomasterfrom
context-to-di

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented May 22, 2020

Do you want to get rid of $this->context?

 class SomeClass
 {
     /**
      * @var \Nette\DI\Container
      */
     private $context;

+    /**
+     * @var SomeTypeToInject
+     */
+    private $someTypeToInject;
+
+    public function __construct(SomeTypeToInject $someTypeToInject)
+    {
+        $this->someTypeToInject = $someTypeToInject;
+    }
+
     public function run()
     {
-        $someTypeToInject = $this->context->getByType(SomeTypeToInject::class);
+        $someTypeToInject = $this->someTypeToInject;
     }
 }

@TomasVotruba TomasVotruba merged commit b98340f into master May 22, 2020
@TomasVotruba TomasVotruba deleted the context-to-di branch May 22, 2020 07:31
TomasVotruba added a commit that referenced this pull request Feb 22, 2023
rectorphp/rector-src@b2d6fa6 Revert recursive check on always array param on phpstan 1.10 on AddMethodCallBasedStrictParamTypeRector (#3399)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant