Skip to content

Add RemoveFuncCallArgRector, ClearReturnNewByReferenceRector, RemoveIniGetSetFuncCallRector, ReplaceHttpServerVarsByServerRector#3455

Merged
TomasVotruba merged 6 commits intomasterfrom
remove-func-arg
May 31, 2020
Merged

Add RemoveFuncCallArgRector, ClearReturnNewByReferenceRector, RemoveIniGetSetFuncCallRector, ReplaceHttpServerVarsByServerRector#3455
TomasVotruba merged 6 commits intomasterfrom
remove-func-arg

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented May 31, 2020

These rules were created in cooperation with @afilina to help legacy code cleanup

@TomasVotruba TomasVotruba changed the title Add RemoveFuncCallArgRector Add RemoveFuncCallArgRector, @TomasVotruba [PHP 5.3] Add ClearReturnNewByReferenceRector May 31, 2020
@TomasVotruba TomasVotruba changed the title Add RemoveFuncCallArgRector, @TomasVotruba [PHP 5.3] Add ClearReturnNewByReferenceRector Add RemoveFuncCallArgRector, [PHP 5.3] Add ClearReturnNewByReferenceRector May 31, 2020
Comment on lines +16 to +22
* @sponsor Thanks https://twitter.com/afilina for sponsoring this rule

* @see https://3v4l.org/UJN6H
* @see \Rector\Php53\Rector\Assign\ClearReturnNewByReferenceRector
*/
final class ClearReturnNewByReferenceRector extends AbstractRector
{
Copy link
Copy Markdown
Member Author

@TomasVotruba TomasVotruba May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @afilina,

we have this habit in Rector, that any person/company that sponsors more rules that are useful and shared with community,
will get this "sponsor badge" above each sponsored rule as a small "thank you" for doing so.

Is this line ok? We can link also website. e.g.

* @sponsor Thanks https://twitter.com/afilina for sponsoring this rule - visit her on https://www.youtube.com/c/AnnaFilina

@TomasVotruba TomasVotruba changed the title Add RemoveFuncCallArgRector, [PHP 5.3] Add ClearReturnNewByReferenceRector Add RemoveFuncCallArgRector, ClearReturnNewByReferenceRector, RemoveIniGetSetFuncCallRector May 31, 2020
@TomasVotruba TomasVotruba changed the title Add RemoveFuncCallArgRector, ClearReturnNewByReferenceRector, RemoveIniGetSetFuncCallRector Add RemoveFuncCallArgRector, ClearReturnNewByReferenceRector, RemoveIniGetSetFuncCallRector, RemoveIniGetSetFuncCallRector May 31, 2020
@TomasVotruba TomasVotruba changed the title Add RemoveFuncCallArgRector, ClearReturnNewByReferenceRector, RemoveIniGetSetFuncCallRector, RemoveIniGetSetFuncCallRector Add RemoveFuncCallArgRector, ClearReturnNewByReferenceRector, RemoveIniGetSetFuncCallRector, ReplaceHttpServerVarsByServerRector May 31, 2020
@TomasVotruba TomasVotruba merged commit c014031 into master May 31, 2020
@TomasVotruba TomasVotruba deleted the remove-func-arg branch June 3, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant