Add function call inside string test case#4836
Closed
budziam wants to merge 1 commit into
Closed
Conversation
Member
|
Test case looks good, why closing? |
Author
|
@TomasVotruba I closed it because there was the following issue with tests |
Member
|
That's correct. The message is saying what to do:
|
TomasVotruba
added a commit
that referenced
this pull request
Aug 23, 2023
rectorphp/rector-src@4163578 Bump dev dependencies (#4836)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR provides a test case which fails with the current implementation of
DowngradeTrailingCommasInFunctionCallsRector