Skip to content

Add function call inside string test case#4836

Closed
budziam wants to merge 1 commit into
rectorphp:masterfrom
budziam:master
Closed

Add function call inside string test case#4836
budziam wants to merge 1 commit into
rectorphp:masterfrom
budziam:master

Conversation

@budziam

@budziam budziam commented Dec 9, 2020

Copy link
Copy Markdown

This MR provides a test case which fails with the current implementation of DowngradeTrailingCommasInFunctionCallsRector

    ---------- begin diff ----------
--- Original
+++ New
@@ -1,3 +1,3 @@
 <?php

-$value = "{$this->method("test")}";
+$value = "{{$this->method("test")}}";
    ----------- end diff -----------

@TomasVotruba

Copy link
Copy Markdown
Member

Test case looks good, why closing?

@budziam

budziam commented Dec 10, 2020

Copy link
Copy Markdown
Author

@TomasVotruba I closed it because there was the following issue with tests

Rector\Core\Exception\Testing\SuperfluousAfterContentFixtureException: The part after "-----" can be removed in "rules/downgrade-php73/tests/Rector/FuncCall/DowngradeTrailingCommasInFunctionCallsRector/Fixture/function_call_inside_string.php.inc" file. It is the same as top half, so no change is required.

https://github.com/rectorphp/rector/runs/1525995354

@TomasVotruba

TomasVotruba commented Dec 11, 2020

Copy link
Copy Markdown
Member

That's correct. The message is saying what to do:

The part after "-----" can be removed

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants