[Downgrade] Apply trailing commas rule also on func/method/static call#4878
Merged
TomasVotruba merged 10 commits intomasterfrom Dec 14, 2020
Merged
Conversation
…ub.com:rectorphp/rector into downgrade-trailing-commas-in-constructor-issue
Contributor
Author
|
Must be fixed also for constructor calls: $object = new ConfiguredCodeSample(
$codeSampleFrom,
- $codeSampleTo,
+ $codeSampleTo
);Working on it now |
Contributor
Contributor
Author
|
Nops, they are all based on master. All those same changes are being added by the Rector Rectify bot |
Member
|
Thank you 👍 Could you make a failing test fixture for the class const fetch rename? |
Contributor
Author
Sorry for asking, but I'm a bit confused. You mean to test downgrading |
Member
|
For these #4878 (comment) |
TomasVotruba
added a commit
that referenced
this pull request
Aug 29, 2023
rectorphp/rector-src@6424bae [TypeDeclaration] Using ClassMethodReturnTypeOverrideGuard on ReturnTypeFromStrictParamRector (#4878)
TomasVotruba
added a commit
that referenced
this pull request
Aug 29, 2023
rectorphp/rector-src@6424bae [TypeDeclaration] Using ClassMethodReturnTypeOverrideGuard on ReturnTypeFromStrictParamRector (#4878)
TomasVotruba
added a commit
that referenced
this pull request
Aug 29, 2023
rectorphp/rector-src@6424bae [TypeDeclaration] Using ClassMethodReturnTypeOverrideGuard on ReturnTypeFromStrictParamRector (#4878)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DowngradeTrailingCommasInParamUseRectorwas downgrading code on the definition of the function only, but not when calling the function:This PR fixes it: