Change RemoveConfiguratorConstantsRector to generic RenameClassConstantsUseToStringsRector

packages/Nette/src/Rector/Bootstrap/RemoveConfiguratorConstantsRector.php → src/Rector/Constant/RenameClassConstantsUseToStringsRector.php

@@ -1,33 +1,53 @@
 <?php declare(strict_types=1);
 
-namespace Rector\Nette\Rector\Bootstrap;
+namespace Rector\Rector\Constant;
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\ClassConstFetch;
 use PhpParser\Node\Expr\Variable;
-use PhpParser\Node\Identifier;
 use PhpParser\Node\Name\FullyQualified;
 use Rector\Node\Attribute;
 use Rector\Node\NodeFactory;
 use Rector\Rector\AbstractRector;
 use Rector\RectorDefinition\CodeSample;
 use Rector\RectorDefinition\RectorDefinition;
 
-final class RemoveConfiguratorConstantsRector extends AbstractRector
+final class RenameClassConstantsUseToStringsRector extends AbstractRector
 {
     /**
      * @var NodeFactory
      */
     private $nodeFactory;
 
-    public function __construct(NodeFactory $nodeFactory)
-    {
+    /**
+     * @var string
+     */
+    private $class;
+
+    /**
+     * @var string[]
+     */
+    private $oldConstantToNewValue = [];
+
+    /**
+     * @param string[] $oldConstantToNewValue
+     */
+    public function __construct(
+        NodeFactory $nodeFactory,
+        string $class = 'Nette\Configurator',
+        array $oldConstantToNewValue = [
+            'DEVELOPMENT' => 'development',
+            'PRODUCTION' => 'production',
+        ]
+    ) {
         $this->nodeFactory = $nodeFactory;
+        $this->class = $class;
+        $this->oldConstantToNewValue = $oldConstantToNewValue;
     }
 
     public function getDefinition(): RectorDefinition
     {
-        return new RectorDefinition('Turns properties with @inject to private properties and constructor injection', [
+        return new RectorDefinition('Replaces constant by value', [
             new CodeSample('$value === Nette\Configurator::DEVELOPMENT', '$value === "development"'),
         ]);
     }
@@ -40,24 +60,21 @@ public function isCandidate(Node $node): bool
 
         $className = $this->getClassNameFromClassConstFetch($node);
 
-        if ($className !== 'Nette\Configurator') {
+        if ($className !== $this->class) {
             return false;
         }
 
-        return in_array((string) $node->name, ['DEVELOPMENT', 'PRODUCTION'], true);
+        return in_array((string) $node->name, array_keys($this->oldConstantToNewValue), true);
     }
 
     /**
      * @param ClassConstFetch $classConstFetchNode
      */
     public function refactor(Node $classConstFetchNode): ?Node
     {
-        /** @var Identifier $constantName */
-        $constantName = $classConstFetchNode->name;
-
-        $originalConstantValue = $constantName->toLowerString();
+        $newValue = $this->oldConstantToNewValue[(string) $classConstFetchNode->name];
 
-        return $this->nodeFactory->createString($originalConstantValue);
+        return $this->nodeFactory->createString($newValue);
     }
 
     private function getClassNameFromClassConstFetch(ClassConstFetch $classConstFetchNode): string

packages/Nette/tests/Rector/Bootstrap/RemoveConfiguratorConstantsRector/RemoveConfiguratorConstantsRectorTest.php → tests/Rector/Constant/RenameClassConstantsUseToStringsRector/RenameClassConstantsUseToStringsRectorTest.php

@@ -1,14 +1,14 @@
 <?php declare(strict_types=1);
 
-namespace Rector\Nette\Tests\Rector\Bootstrap\RemoveConfiguratorConstantsRector;
+namespace Rector\Tests\Rector\Constant\RenameClassConstantsUseToStringsRector;
 
 use Iterator;
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 
 /**
- * @covers \Rector\Nette\Rector\Bootstrap\RemoveConfiguratorConstantsRector
+ * @covers \Rector\Rector\Constant\RenameClassConstantsUseToStringsRector
  */
-final class RemoveConfiguratorConstantsRectorTest extends AbstractRectorTestCase
+final class RenameClassConstantsUseToStringsRectorTest extends AbstractRectorTestCase
 {
     /**
      * @dataProvider provideWrongToFixedFiles()

tests/Rector/Constant/RenameClassConstantsUseToStringsRector/config.yml

@@ -0,0 +1,2 @@
+services:
+    Rector\Rector\Constant\RenameClassConstantsUseToStringsRector: ~