Add test for PropertyFetchTypeResolver#5307
Closed
vhenzl wants to merge 4 commits intorectorphp:masterfrom
Closed
Conversation
Contributor
Author
|
@TomasVotruba Is it possible to have tests and fixtures targeting only PHP 7.4+ (or even PHP 8.0+) to test typed properties (and native union types)? What's the recommended way to exclude files like |
Member
|
You can create a test like Php74Test in: that uses |
fc18650 to
f1c1978
Compare
aeed121 to
05bc070
Compare
Contributor
Author
|
This is ready now. Tests are expected to fail because |
Member
Member
|
Handled at #5334 |
TomasVotruba
added a commit
that referenced
this pull request
Dec 2, 2023
rectorphp/rector-src@71c22e2 [CodeQuality] Skip with else on SimplifyForeachToCoalescingRector (#5307)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing test for
PropertyFetchTypeResolver. See #5299 (comment) for the motivation.Currently based on v0.9.10 which is the last version where property fetch type resolution worked (although with some errors as the test reveals). Will be rebased later.