Fix url to nodes-overview #5695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Feb 27, 2021
docs/create_own_rule.md
Outdated
| { | ||
| // what node types are we looking for? | ||
| // pick any node from https://github.com/rectorphp/rector/blob/master/docs/nodes_overview.md | ||
| // pick any node from https://github.com/rectorphp/php-parser-nodes-docs/blob/master/docs/nodes_overview.md |
Contributor
Author
There was a problem hiding this comment.
At least this is the url used in the rector readme
Member
There was a problem hiding this comment.
Thank for the PR
What about https://github.com/rectorphp/php-parser-nodes-docs/ for both sources?
Contributor
Author
There was a problem hiding this comment.
Thats what this PR achieves. In the readme the url https://github.com/rectorphp/php-parser-nodes-docs/blob/master/docs/nodes_overview.md Is already used
Member
There was a problem hiding this comment.
I mean direct repository link: https://github.com/rectorphp/php-parser-nodes-docs/
The docs is in README.md now too as less surprising location.
The old link is just for BC :)
Contributor
Author
There was a problem hiding this comment.
Adjusted per feedback
Member
|
Thank you |
TomasVotruba
added a commit
that referenced
this pull request
Mar 6, 2024
rectorphp/rector-src@643814d [TypeDeclaration] Add ChildDoctrineRepositoryClassTypeRector (#5695)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.