add ability to assign database role to a user - #69
Merged
Merged
Conversation
simonlye
approved these changes
Jul 28, 2026
The unless guard for assigning a role was missing USE [database], so IS_ROLEMEMBER ran against the wrong database and the ALTER ROLE command never actually executed. Also quote identifiers consistently, use sys.database_principals instead of the deprecated sysusers view, add a serverspec assertion that the role assignment took effect, and note why kitchen-vagrant is pinned to a fork. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a helper to allow us to more easily assign a database role to a given server login.
If a user for the login doesn't exist on the database in question, then it gets created.