This repository was archived by the owner on Apr 2, 2026. It is now read-only.
enhance: Always retry writing binlogs (#46850)#12
Merged
Xinyi7 merged 1 commit intofeatures/v2.6.6-patched-251123from Jan 8, 2026
Merged
enhance: Always retry writing binlogs (#46850)#12Xinyi7 merged 1 commit intofeatures/v2.6.6-patched-251123from
Xinyi7 merged 1 commit intofeatures/v2.6.6-patched-251123from
Conversation
issue: milvus-io#46848 Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
kumaramit01
approved these changes
Jan 7, 2026
kumaramit01
suggested changes
Jan 7, 2026
| assert.Equal(t, 16*1024*1024, Params.ImportBaseBufferSize.GetAsInt()) | ||
| assert.Equal(t, 16*1024*1024, Params.ImportDeleteBufferSize.GetAsInt()) | ||
| assert.Equal(t, 10.0, Params.ImportMemoryLimitPercentage.GetAsFloat()) | ||
| assert.Equal(t, 0, Params.ImportMaxWriteRetryAttempts.GetAsInt()) |
Collaborator
There was a problem hiding this comment.
Set the default to something reasonable -by default we should just retry forever...
Author
There was a problem hiding this comment.
this is only for import binlog writes in datanode. we could set timeout for the import job or manually kill the job if we want
Author
There was a problem hiding this comment.
milvus does inifinite retry in another places already: https://github.com/milvus-io/milvus/blob/4065c86040ae2975c88f7c5a0f2f6c975e37c6de/internal/flushcommon/writebuffer/write_buffer.go#L624
Collaborator
There was a problem hiding this comment.
This is pretty dangerous... -but I don;t think there is an easy solution for now.
kumaramit01
approved these changes
Jan 8, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: milvus-io#46848
Closes #
💸 TL;DR
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks