Address SME feedback across all documentation pages#134
Merged
Roming22 merged 2 commits intoredhat-appstudio:mainfrom Apr 9, 2026
Merged
Address SME feedback across all documentation pages#134Roming22 merged 2 commits intoredhat-appstudio:mainfrom
Roming22 merged 2 commits intoredhat-appstudio:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gtrivedi88
changed the title
- Fix bad Quay OAuth application link (preparing-to-install)
- Add GitLab env vars (GITLAB__HOST, GITLAB__GROUP, GITLAB__TOKEN) to tsf.env
- Replace {TSFInstallerImage} attribute with actual image path (installing)
- Use env vars from tsf.env in GitLab config commands (installing)
- Add default-tenant namespace note and Konflux docs link (installing)
- Move config.yaml blurb from Verifying to Installing page
- Fix PR description: "build pipeline definition" → "Tekton pipeline definitions"
- Add oc get integrationtestscenarios command (getting-started)
- Fix CI checks: clarify GH App vs GL webhook integration differences
- Add table of contents with section anchors (troubleshooting)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gtrivedi88
force-pushed
the
docs/fix-quay-link
branch
from
ffd4c7d to
a0ac6d5
Compare
Roming22
approved these changes
Apr 9, 2026
Roming22
reviewed
Apr 9, 2026
| ---- | ||
|
|
||
| . **Creates CI checks** on the pull request (GitHub checks or GitLab webhooks, depending on your Git provider). Two checks appear: | ||
| . **Creates CI checks** on the pull request. {KonfluxName} creates checks for both GitHub and GitLab. The difference is how the integration with {KonfluxName} is managed: for GitHub, a GitHub App is created ahead of time during installation; for GitLab, the webhook is created when the repository is onboarded. Two checks appear: |
Member
There was a problem hiding this comment.
Remove that bit.
Add For GitLab the webhook is created and configured in the repository. under the After you create a component, {KonfluxName} automatically section.
Roming22
reviewed
Apr 9, 2026
| oc create secret generic gitlab-auth-secret \ | ||
| -n <tenant-namespace> \ | ||
| --from-literal=password=<project-access-token> \ | ||
| --from-literal=password="$GITLAB__TOKEN" \ |
Member
There was a problem hiding this comment.
All this section is going to much simplified by RHTAP-6483.
gtrivedi88
added a commit
to gtrivedi88/tsf-cli
that referenced
this pull request
Apr 13, 2026
RHTAP-6483: Replace manual oc create/label/annotate secret commands with tsf integration gitlab CLI command. The installer handles namespace and secret creation for default-tenant during deployment. PR redhat-appstudio#134 review: Remove GH App vs GL webhook detail from CI checks description. Add GitLab webhook note per SME feedback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all SME feedback items:
Preparing to install:
docs.quay.io/glossary/organizations.html)docs.quay.io/glossary/access-token.html)GITLAB__HOST,GITLAB__GROUP,GITLAB__TOKEN) totsf.envexample and variable tableInstalling:
{TSFInstallerImage}attribute with actual image pathquay.io/redhat-ads/tsf-cli:unstable$GITLAB__TOKENand$GITLAB__HOSTenv vars fromtsf.envin GitLab config commandsdefault-tenantis the default namespace, with link to Konflux docs, and note about multiple namespacesconfig.yaml/tsf-configConfigMap blurb from Verifying page to Installing page (Configure the cluster section)Getting started:
oc get integrationtestscenarioscommand to view integration test CRVerifying and accessing:
Troubleshooting:
Test plan