Simplify GitLab integration per RHTAP-6483#138
Merged
Roming22 merged 1 commit intoredhat-appstudio:mainfrom Apr 13, 2026
Merged
Simplify GitLab integration per RHTAP-6483#138Roming22 merged 1 commit intoredhat-appstudio:mainfrom
Roming22 merged 1 commit intoredhat-appstudio:mainfrom
Conversation
RHTAP-6483: Replace manual oc create/label/annotate secret commands with tsf integration gitlab CLI command. The installer handles namespace and secret creation for default-tenant during deployment. PR redhat-appstudio#134 review: Remove GH App vs GL webhook detail from CI checks description. Add GitLab webhook note per SME feedback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jkopriva
reviewed
Apr 13, 2026
| appstudio.redhat.com/scm.host="$GITLAB__HOST" | ||
| tsf integration gitlab \ | ||
| --group="$GITLAB__GROUP" \ | ||
| --host="$GITLAB__HOST" \ |
Collaborator
There was a problem hiding this comment.
I would put here some example, that is must be without https:.... for example: --host="gitlab.com"
Member
There was a problem hiding this comment.
This is already specified in https://redhat-appstudio.github.io/tsf-cli/tsf/preparing-to-install.html#steps, where all vars are documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oc create secret/oc label/oc annotatecommands withtsf integration gitlabCLI command. The manual commands fail because the tenant namespace does not exist at that point in the install flow. The installer handles namespace and secret creation fordefault-tenantduring deployment.Test plan
tsf integration gitlabcommand matches installer behavioroc get secret tsf-gitlab-integration -n tsfreturns the secret after deployment