Fix chapter 3 for knative v0.4.0#105
Merged
kameshsampath merged 1 commit intoredhat-developer-demos:masterfrom Apr 3, 2019
Merged
Fix chapter 3 for knative v0.4.0#105kameshsampath merged 1 commit intoredhat-developer-demos:masterfrom
kameshsampath merged 1 commit intoredhat-developer-demos:masterfrom
Conversation
Our previous approach for editing the configmap broke because the autoscaler configmap went from defining the defaults to providing examples in the configmap on variables to change. To get around this and keep the changes around this section minimal, we've added a small configmap to apply that will set this defaults explicitly. The remainder of the section (with yq invocations) will work as advertised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our previous approach for editing the configmap broke because the
autoscaler configmap went from defining the defaults to providing
examples in the configmap on variables to change.
To get around this and keep the changes around this section minimal,
we've added a small configmap to apply that will set this defaults
explicitly. The remainder of the section (with yq invocations) will
work as advertised.