Update basics chapter for knative v0.4.0#89
Merged
kameshsampath merged 1 commit intoredhat-developer-demos:masterfrom Mar 29, 2019
Merged
Update basics chapter for knative v0.4.0#89kameshsampath merged 1 commit intoredhat-developer-demos:masterfrom
kameshsampath merged 1 commit intoredhat-developer-demos:masterfrom
Conversation
The serving 'pinned' keyword is being deprecated, so move over to using 'release' and 'revisions' for forward compat.
lberk
force-pushed
the
pinned-version-fix
branch
from
09f22e5 to
1228552
Compare
Contributor
|
/lgtm - with just one question whether the revision name generation is still same like |
Contributor
Author
|
Hi, no the revision names don't match 00001. Addressing that is outside the scope of the PR, and the change keeps consistent with the remainder of the contents as they currently stand. |
Contributor
|
thanks @lberk - will merge soon once I fix the CI |
Contributor
|
thanks @lberk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serving 'pinned' keyword is being deprecated, so move over to
using 'release' and 'revisions' for forward compat.