-
Couldn't load subscription status.
- Fork 28
Add Gitsource and GitsourceAnalysis e2e tests #166
base: master
Are you sure you want to change the base?
Conversation
|
/test lint |
test/e2e/gitsource_test.go
Outdated
| Namespace: namespace, | ||
| }, | ||
| Spec: devconsoleapi.GitSourceSpec{ | ||
| URL: "https://somegit.con/myrepo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.com
test/e2e/gitsourceanalysis_test.go
Outdated
| Namespace: namespace, | ||
| }, | ||
| Spec: devconsoleapi.GitSourceSpec{ | ||
| URL: "https://somegit.con/myrepo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.com
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Avni-Sharma If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@akashshinde you might want to rebase. Under make/lint.mk the deadline has been changed from 10m to 30m. Maybe that's y the prow/lint is failing |
| package e2e | ||
|
|
||
| import ( | ||
| goctx "context" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why alias? There is no other context here, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baijum alias can be removed
|
/test e2e |
|
The |
|
@akashshinde Can you merge changes from upstream/master and run tests again. I am wondering why the |
|
@baijum I am going to merge upstream/master now, I am wondering that also since |
* upstream/master: Set registry log (redhat-developer#176) Non-admin user viewing the console with developer console perspective (redhat-developer#136) Use the base image available in the OpenShift CI (redhat-developer#175)
|
/test test |
|
/retest |
|
@akashshinde: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR adds e2e tests for GitSource and GitSourceAnanlysis.
To test this PR execute.