Skip to content
This repository was archived by the owner on Oct 3, 2019. It is now read-only.

Conversation

@akashshinde
Copy link
Collaborator

@akashshinde akashshinde commented Apr 30, 2019

This PR adds e2e tests for GitSource and GitSourceAnanlysis.
To test this PR execute.

make test-e2e

@Avni-Sharma
Copy link
Contributor

/test lint

Namespace: namespace,
},
Spec: devconsoleapi.GitSourceSpec{
URL: "https://somegit.con/myrepo",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.com

Namespace: namespace,
},
Spec: devconsoleapi.GitSourceSpec{
URL: "https://somegit.con/myrepo",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Avni-Sharma
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sbose78

If they are not already assigned, you can assign the PR to them by writing /assign @sbose78 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Avni-Sharma
Copy link
Contributor

@akashshinde you might want to rebase. Under make/lint.mk the deadline has been changed from 10m to 30m. Maybe that's y the prow/lint is failing

@akashshinde akashshinde changed the title [WIP] Add Gitsource and GitsourceAnalysis e2e tests Add Gitsource and GitsourceAnalysis e2e tests May 2, 2019
package e2e

import (
goctx "context"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why alias? There is no other context here, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baijum alias can be removed

@baijum
Copy link
Collaborator

baijum commented May 2, 2019

/test e2e

@baijum
Copy link
Collaborator

baijum commented May 2, 2019

The e2eutils.go file name suggests generic utility functions. Since the functions are waiting related, how about renaming it to wait.go?

@baijum
Copy link
Collaborator

baijum commented May 3, 2019

@akashshinde Can you merge changes from upstream/master and run tests again.

I am wondering why the e2e test is failing!

@akashshinde
Copy link
Collaborator Author

@baijum I am going to merge upstream/master now, I am wondering that also since e2e tests are passing locally.

* upstream/master:
  Set registry log (redhat-developer#176)
  Non-admin user viewing the console with developer console perspective (redhat-developer#136)
  Use the base image available in the OpenShift CI (redhat-developer#175)
@akashshinde
Copy link
Collaborator Author

/test test

@sbose78
Copy link
Member

sbose78 commented May 3, 2019

/retest

@openshift-ci-robot
Copy link
Collaborator

@akashshinde: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e 98bc76b link /test e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants