Skip to content

fix: cherry-pick getAppSetStatus incorrectly treats ApplicationSetUpToDate=True ass Error to release-4.18 branch - #285

Merged
keithchong merged 1 commit into
redhat-developer:release-4.18from
aali309:GITOPS-11094-4.18
Sep 1, 2026
Merged

fix: cherry-pick getAppSetStatus incorrectly treats ApplicationSetUpToDate=True ass Error to release-4.18 branch#285
keithchong merged 1 commit into
redhat-developer:release-4.18from
aali309:GITOPS-11094-4.18

Conversation

@aali309

@aali309 aali309 commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Cherry-picked: #284 to release-4.18 branch

…s Error

Signed-off-by: Atif Ali <atali@redhat.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-4.18@f99321a). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-4.18     #285   +/-   ##
===============================================
  Coverage                ?   12.40%           
===============================================
  Files                   ?      171           
  Lines                   ?     6835           
  Branches                ?     2257           
===============================================
  Hits                    ?      848           
  Misses                  ?     5986           
  Partials                ?        1           
Flag Coverage Δ
unit-tests 12.40% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 6adeb88b-fbe1-4903-b26a-ad0b721259bc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@keithchong keithchong left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the cherry-pick

@keithchong
keithchong merged commit 146f97e into redhat-developer:release-4.18 Sep 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants