Skip to content

fix: release-4.18: enable Delete ApplicationSet (and Apps) for namespace-scoped users (#10780) - #289

Merged
keithchong merged 1 commit into
redhat-developer:release-4.18from
keithchong:release-4.18-10780-DeleteActionDisabledFix
Sep 2, 2026
Merged

fix: release-4.18: enable Delete ApplicationSet (and Apps) for namespace-scoped users (#10780)#289
keithchong merged 1 commit into
redhat-developer:release-4.18from
keithchong:release-4.18-10780-DeleteActionDisabledFix

Conversation

@keithchong

Copy link
Copy Markdown
Collaborator

See GITOPS-10780, but this is for the release-4.18 branch. See also #287

@openshift-ci
openshift-ci Bot requested review from aali309 and wtam2018 September 1, 2026 22:08
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f95aabf4-1f2d-4be7-8f22-2f5fc6b4d72d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-4.18@146f97e). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-4.18     #289   +/-   ##
===============================================
  Coverage                ?   12.44%           
===============================================
  Files                   ?      171           
  Lines                   ?     6836           
  Branches                ?     2247           
===============================================
  Hits                    ?      851           
  Misses                  ?     5984           
  Partials                ?        1           
Flag Coverage Δ
unit-tests 12.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@keithchong keithchong changed the title fix: release-4.18: Delete action disabled (#10780) fix: release-4.18: enable Delete ApplicationSet for namespace-scoped users (#10780) Sep 1, 2026

@aali309 aali309 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, same as #287

Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong
keithchong force-pushed the release-4.18-10780-DeleteActionDisabledFix branch from 8623e38 to 0266c88 Compare September 2, 2026 16:18
@keithchong keithchong changed the title fix: release-4.18: enable Delete ApplicationSet for namespace-scoped users (#10780) fix: release-4.18: enable Delete ApplicationSet (and Apps) for namespace-scoped users (#10780) Sep 2, 2026
@keithchong
keithchong merged commit b7bfe29 into redhat-developer:release-4.18 Sep 2, 2026
5 checks passed
@keithchong

Copy link
Copy Markdown
Collaborator Author

Thanks Atif for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants