Add unit tests for health & application set status - #290
Conversation
Signed-off-by: trdoyle <trdoyle@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe change adds a shared ChangesApplicationSet status rendering
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR adds coverage for health, sync, and ApplicationSet status behavior with localized UI changes; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 5 files. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
+ Coverage 11.30% 12.76% +1.46%
==========================================
Files 169 172 +3
Lines 6679 6839 +160
Branches 2235 2310 +75
==========================================
+ Hits 755 873 +118
+ Misses 5923 5725 -198
- Partials 1 241 +240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
keithchong
left a comment
There was a problem hiding this comment.
Looks good. The tests passed for me.
Adding unit tests for Health, Sync, and ApplicationSet status UI
covers:
-Health: Suspended, Missing, undefined, unrecognised icon
-Sync: undefined status
-ApplicationSet: Healthy / Error / Unknown / empty
Jira:
GITOPS-10536
Note:
Will need to be ported to
release-4.18aswell.Run tests:
$ pnpm test
$ pnpm test -- src/gitops/Statuses/HealthStatus.test.tsx src/gitops/Statuses/SyncStatus.test.tsx src/gitops/Statuses/ApplicationSetStatus.test.tsx