chore: run 'go fix' and audit changes

[jgwest]

What type of PR is this?
/kind cleanup

What does this PR do / why we need it:

Go 1.26 includes a new 'go fix' implementation which modernizes Go codebases. See go fix blog for details.

This PR:

• I ran 'go fix' from go version go1.26.3 linux/amd64.
• I manually verified all the changes.
• Finally, I asked Claude to review for correctness:

 No correctness bugs found. All changes are semantically equivalent to the original code and compile/test cleanly on Go 1.26.

See also argoproj-labs/argocd-agent#1035

Have you updated the necessary documentation?

• Documentation update is required by this PR.
• Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

• Unit Test
• E2E Test

How to test changes / Special notes to the reviewer:

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 24a44c13-cd0a-4d15-8dcd-766e843ae642

📥 Commits

Reviewing files that changed from the base of the PR and between 5a448d9 and e3f98b4.

📒 Files selected for processing (48)

• controllers/argocd/openshift/openshift.go
• controllers/consoleplugin.go
• controllers/consoleplugin_test.go
• controllers/gitopsservice_controller_test.go
• controllers/util/util.go
• test/e2e/gitopsservice_test.go
• test/openshift/e2e/ginkgo/parallel/1-003_alpha_to_beta_sso_conflict_conversion_test.go
• test/openshift/e2e/ginkgo/parallel/1-005_validate_route_tls_test.go
• test/openshift/e2e/ginkgo/parallel/1-007_validate_volume_mounts_test.go
• test/openshift/e2e/ginkgo/parallel/1-019_validate_volume_mounts_test.go
• test/openshift/e2e/ginkgo/parallel/1-030_validate_reencrypt_test.go
• test/openshift/e2e/ginkgo/parallel/1-031_validate_toolchain_test.go
• test/openshift/e2e/ginkgo/parallel/1-032_validate_dynamic_scaling_test.go
• test/openshift/e2e/ginkgo/parallel/1-034_validate_webhook_notifications_test.go
• test/openshift/e2e/ginkgo/parallel/1-037_validate_argocd_setting_replicas_test.go
• test/openshift/e2e/ginkgo/parallel/1-042_restricted_pss_compliant_test.go
• test/openshift/e2e/ginkgo/parallel/1-045_validate_applicationset_image_override_test.go
• test/openshift/e2e/ginkgo/parallel/1-045_validate_repo_exec_timeout_test.go
• test/openshift/e2e/ginkgo/parallel/1-050_validate_sso_test.go
• test/openshift/e2e/ginkgo/parallel/1-057_validate_notifications_test.go
• test/openshift/e2e/ginkgo/parallel/1-064_validate_security_contexts_test.go
• test/openshift/e2e/ginkgo/parallel/1-070_validate_config_management_plugin_test.go
• test/openshift/e2e/ginkgo/parallel/1-080_validate_regex_support_argocd_rbac_test.go
• test/openshift/e2e/ginkgo/parallel/1-088_validate_applicationset_add_env_vars_test.go
• test/openshift/e2e/ginkgo/parallel/1-099_validate_server_autoscale_test.go
• test/openshift/e2e/ginkgo/parallel/1-104_validate_applicationset_tls_scm_volume_mount_test.go
• test/openshift/e2e/ginkgo/parallel/1-115_validate_controller_extra_command_args_test.go
• test/openshift/e2e/ginkgo/parallel/1-124_validate_networkpolicies_test.go
• test/openshift/e2e/ginkgo/parallel/1-125_validate_applicationset_cleanup_when_spec_field_omitted_test.go
• test/openshift/e2e/ginkgo/parallel/1-126_validate_servicemonitor_metrics_config_test.go
• test/openshift/e2e/ginkgo/sequential/1-006_validate_machine_config_test.go
• test/openshift/e2e/ginkgo/sequential/1-037_validate_applicationset_in_any_namespace_test.go
• test/openshift/e2e/ginkgo/sequential/1-051_validate_argocd_agent_principal_test.go
• test/openshift/e2e/ginkgo/sequential/1-052_validate_argocd_agent_agent_test.go
• test/openshift/e2e/ginkgo/sequential/1-053_validate_argocd_agent_principal_connected_test.go
• test/openshift/e2e/ginkgo/sequential/1-071_validate_SCC_HA_test.go
• test/openshift/e2e/ginkgo/sequential/1-074_validate_terminating_namespace_block_test.go
• test/openshift/e2e/ginkgo/sequential/1-085_validate_dynamic_plugin_installation_test.go
• test/openshift/e2e/ginkgo/sequential/1-086_validate_default_argocd_role_test.go
• test/openshift/e2e/ginkgo/sequential/1-102_validate_handle_terminating_namespaces_test.go
• test/openshift/e2e/ginkgo/sequential/1-105_validate_default_argocd_route_test.go
• test/openshift/e2e/ginkgo/sequential/1-105_validate_label_selector_test.go
• test/openshift/e2e/ginkgo/sequential/1-106_validate_argocd_metrics_controller_test.go
• test/openshift/e2e/ginkgo/sequential/1-108_alternate_cluster_roles_cluster_scoped_instance_test.go
• test/openshift/e2e/ginkgo/sequential/1-111_validate_default_argocd_route_test.go
• test/openshift/e2e/ginkgo/sequential/1-120_repo_server_system_ca_trust.go
• test/openshift/e2e/ginkgo/sequential/1-120_validate_running_must_gather.go
• test/openshift/e2e/ginkgo/sequential/1-121-valiate_resource_constraints_gitopsservice_test.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• argoproj-labs/argocd-operator (manual)

---

📝 Walkthrough

Summary by CodeRabbit

• Refactor

  • Modernized internal Go code to use current language features and simpler standard-library utilities.
  • Standardized configuration of pointer-valued settings across controllers and validation scenarios.
  • Removed an obsolete helper without changing runtime behavior.

• Tests

  • Updated automated validation coverage to use the streamlined configuration patterns.
  • Improved security-context validation coverage for controller workloads.
  • Preserved existing test expectations and behavior while reducing unnecessary allocations.

Walkthrough

The change replaces ptr.To, util.BoolPtr, interface{}, manual membership loops, and slice-based line parsing with Go standard library alternatives. It also updates related controller and end-to-end tests without changing most test behavior.

Changes

Go standard library modernization

Layer / File(s)	Summary
Controller helpers and unit tests controllers/argocd/openshift/openshift.go, controllers/consoleplugin.go, controllers/consoleplugin_test.go, controllers/util/util.go, controllers/gitopsservice_controller_test.go	Controller hooks use any. Namespace checks use slices.Contains. Pointer construction uses new. The exported BoolPtr helper is removed.
Parallel end-to-end test updates test/e2e/*, test/openshift/e2e/ginkgo/parallel/*	Tests replace ptr.To with new and update selected string and index iteration loops.
Sequential end-to-end test updates test/openshift/e2e/ginkgo/sequential/*	Tests replace ptr.To with new, use any, use slices.Contains, and use strings.SplitSeq. One security-context assertion moves from Redis to the notifications controller pod.

Estimated code review effort: 2 (Simple) | ~15 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: running go fix and auditing the resulting modernization changes.
Description check	✅ Passed	The description explains that go fix modernizes the codebase and states that the changes were manually audited.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@jgwest: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.14-kuttl-sequential	e3f98b4	link	false	/test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.