Enable 'Validate granting permissions by label' test#401
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
the
kind/failing-test
|
/test all |
|
/test v4.9-e2e |
2 similar comments
|
/test v4.9-e2e |
|
/test v4.9-e2e |
|
/test all |
|
/test v4.10-e2e |
|
|
||
| export OCP_VERSION="$(oc version)" | ||
| echo $OCP_VERSION | ||
|
|
There was a problem hiding this comment.
If we can avoid the dependency of the env var, that would be better. Folks may run these tests from an IDE without calling the script.
There was a problem hiding this comment.
Thanks @wtam2018, that's a good point. But os.Getenv("OCP_VERSION") will return an empty string when OCP_VERSION is not set (if someone is running the test locally using make target) and we have seen the test passes on the local environment even on 4.9 cluster so I don't think that should be a problem. WDYT?
Signed-off-by: varshab1210 <vab@redhat.com>
Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: varshab1210 <vab@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: varshab1210 <vab@redhat.com>
Signed-off-by: varshab1210 <vab@redhat.com>
varshab1210
force-pushed
the
conditional_skip
branch
from
e06adfa to
62600c5
Compare
Signed-off-by: varshab1210 <vab@redhat.com>
varshab1210
force-pushed
the
conditional_skip
branch
from
06b2a95 to
d835c0e
Compare
|
/test v4.9-e2e |
Signed-off-by: varshab1210 <vab@redhat.com>
varshab1210
force-pushed
the
conditional_skip
branch
2 times, most recently
from
f9af5b0 to
2f2231a
Compare
Signed-off-by: varshab1210 <vab@redhat.com>
varshab1210
force-pushed
the
conditional_skip
branch
from
2f2231a to
b938f3b
Compare
|
/test v4.9-e2e |
varshab1210
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wtam2018 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…r#401) * Skip test based on condition Signed-off-by: varshab1210 <vab@redhat.com> * chore: pick up latest argocd-operator commit Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: varshab1210 <vab@redhat.com> * Add reconcile plugin condition (redhat-developer#402) Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: varshab1210 <vab@redhat.com> * increase timeout and skip condition Signed-off-by: varshab1210 <vab@redhat.com> * Removing additional variable Signed-off-by: varshab1210 <vab@redhat.com> * lowering timeout Signed-off-by: varshab1210 <vab@redhat.com> * Enable test Signed-off-by: varshab1210 <vab@redhat.com> Signed-off-by: varshab1210 <vab@redhat.com> Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: ishitasequeira <ishiseq29@gmail.com> Co-authored-by: Yi Cai <yicai@redhat.com>
5 participants
Signed-off-by: varshab1210 vab@redhat.com
What type of PR is this?
/kind failing-test
What does this PR do / why we need it:
Previously we commented the test out as it was failing constantly on OCP 4.9 blocking the merge process. This PR increases timeout and re-enables the test
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: