GITOPS-2415 Add reconcile plugin condition#402
Merged
openshift-merge-robot merged 1 commit intoNov 23, 2022
Merged
Conversation
Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay
requested review from
jaideepr97,
jopit,
keithchong and
wtam2018
and removed request for
sbose78
4 tasks
iam-veeramalla
approved these changes
Nov 23, 2022
Contributor
iam-veeramalla
left a comment
iam-veeramalla
left a comment
There was a problem hiding this comment.
Approving the change as the changes suggested in the review comments are trivial
| insecureEnvVarValue = "true" | ||
| serviceNamespace = "openshift-gitops" | ||
| deprecatedServiceNamespace = "openshift-pipelines-app-delivery" | ||
| dynamicPluginStartOCPVersionEnv = "DYNAMIC_PLUGIN_START_OCP_VERSION" |
Contributor
There was a problem hiding this comment.
This declaration does not seem to be required.
| } | ||
|
|
||
| return r.reconcilePlugin(instance, request) | ||
| dynamicPluginStartOCPVersion := os.Getenv(dynamicPluginStartOCPVersionEnv) |
Contributor
There was a problem hiding this comment.
Can we directly use DYNAMIC_PLUGIN_START_OCP_VERSION here ?
dynamicPluginStartOCPVersion := os.Getenv(DYNAMIC_PLUGIN_START_OCP_VERSION)
Contributor
|
/lgtm Thanks @ciiay |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iam-veeramalla The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
iam-veeramalla
added a commit
that referenced
this pull request
Nov 23, 2022
…ugin [cherry-pick]: Add reconcile plugin condition (#402)
ciiay
changed the title
varshab1210
pushed a commit
to varshab1210/gitops-operator
that referenced
this pull request
Dec 7, 2022
Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: varshab1210 <vab@redhat.com>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Dec 8, 2022
* Skip test based on condition Signed-off-by: varshab1210 <vab@redhat.com> * chore: pick up latest argocd-operator commit Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: varshab1210 <vab@redhat.com> * Add reconcile plugin condition (#402) Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: varshab1210 <vab@redhat.com> * increase timeout and skip condition Signed-off-by: varshab1210 <vab@redhat.com> * Removing additional variable Signed-off-by: varshab1210 <vab@redhat.com> * lowering timeout Signed-off-by: varshab1210 <vab@redhat.com> * Enable test Signed-off-by: varshab1210 <vab@redhat.com> Signed-off-by: varshab1210 <vab@redhat.com> Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: ishitasequeira <ishiseq29@gmail.com> Co-authored-by: Yi Cai <yicai@redhat.com>
trdoyle81
pushed a commit
to trdoyle81/gitops-operator
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com>
trdoyle81
pushed a commit
to trdoyle81/gitops-operator
that referenced
this pull request
Aug 13, 2024
…r#401) * Skip test based on condition Signed-off-by: varshab1210 <vab@redhat.com> * chore: pick up latest argocd-operator commit Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: varshab1210 <vab@redhat.com> * Add reconcile plugin condition (redhat-developer#402) Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: varshab1210 <vab@redhat.com> * increase timeout and skip condition Signed-off-by: varshab1210 <vab@redhat.com> * Removing additional variable Signed-off-by: varshab1210 <vab@redhat.com> * lowering timeout Signed-off-by: varshab1210 <vab@redhat.com> * Enable test Signed-off-by: varshab1210 <vab@redhat.com> Signed-off-by: varshab1210 <vab@redhat.com> Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: Yi Cai <yicai@redhat.com> Co-authored-by: ishitasequeira <ishiseq29@gmail.com> Co-authored-by: Yi Cai <yicai@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
To avoid multiple "Environments" button showing up in left menu on Developer tab in DevConsole.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes GITOPS-2415
Test acceptance criteria:
How to test changes / Special notes to the reviewer: