Add GOFIPS140 spec to the build commands - #74
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: webbnh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| GODEBUG=fips140=auto CGO_ENABLED=0 GOARCH=amd64 GOOS=linux go build -o "_dist/linux-amd64/$(BINNAME)" $(GOFLAGS) -tags '$(TAGS)' -ldflags '$(LDFLAGS)' ./cmd/helm | ||
| GODEBUG=fips140=auto CGO_ENABLED=0 GOARCH=amd64 GOOS=darwin go build -o "_dist/darwin-amd64/$(BINNAME)" $(GOFLAGS) -tags '$(TAGS)' -ldflags '$(LDFLAGS)' ./cmd/helm | ||
| GODEBUG=fips140=auto CGO_ENABLED=0 GOARCH=arm64 GOOS=darwin go build -o "_dist/darwin-arm64/$(BINNAME)" $(GOFLAGS) -tags '$(TAGS)' -ldflags '$(LDFLAGS)' ./cmd/helm | ||
| GODEBUG=fips140=auto CGO_ENABLED=0 GOARCH=amd64 GOOS=windows go build -o "_dist/windows-amd64/$(BINNAME).exe" $(GOFLAGS) -tags '$(TAGS)' -ldflags '$(LDFLAGS)' ./cmd/helm |
There was a problem hiding this comment.
nit/unrelated: I have noticed an unrelated (out of scope for this PR) inconsistency:
In some v3 versions (and upstream for that matter) a -trimpath flag is used and I think we missed it in some versions of our releases. Its not breaking just something to keep in mind for the next releases for sake of good hygiene. For example in #73 in the build-cross section of a Makefile its correctly used
cc: @webbnh @baijum @sowmya-sl
There was a problem hiding this comment.
Yeah, we need to find a way to have a single source for our local changes, so that we don't end up with a different version of it in each release. That way, when we add something (like -trimpath or GOFIPS140) it ends up being applied consistently (at least as we go forward).
|
/lgtm |
2 participants
This is substantially the same change as in #73 which adds the additional required build switch for FIPS compliance to the
release-4.2.4branch.