feat(tkn): add operator-channel param to infra-aws-ocp-snc task - #873
Conversation
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Tekton ChangesOpenShift SNC provisioning
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tkn/infra-aws-ocp-snc.yaml`:
- Around line 288-292: Remove the eval-based command construction around the
operator-channel handling and execution near the provisioner command, using a
shell array to store fixed arguments and each validated channel value, then
execute the array directly. Read the Tekton operator-channel parameter through
an environment variable rather than interpolating it into shell source,
preserving comma-separated channel handling while preventing caller input from
being reparsed as commands.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b443c821-4c9e-494e-80bd-7cde337f81cd
📒 Files selected for processing (1)
tkn/infra-aws-ocp-snc.yaml
|
Please squash the commits |
910766e to
367dabf
Compare
|
@ppitonak I do not have sufficient permissions in this Repo |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
tkn/infra-aws-ocp-snc.yaml (1)
288-295:⚠️ Potential issue | 🟠 MajorRemove shell-source interpolation and
evalfrom operator-channel handling.The validation is too late because Tekton substitutes the parameter before the shell parses the script. Apply the same safe argument-passing implementation in both manifests:
tkn/infra-aws-ocp-snc.yaml#L288-L295: read the parameter from an environment variable and pass validated entries as direct arguments.tkn/template/infra-aws-ocp-snc.yaml#L288-L295: apply the identical fix to keep the template secure.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tkn/infra-aws-ocp-snc.yaml` around lines 288 - 295, Replace shell-source interpolation and eval-based operator-channel handling in both tkn/infra-aws-ocp-snc.yaml (lines 288-295) and tkn/template/infra-aws-ocp-snc.yaml (lines 288-295). Read operator-channel through an environment variable, validate each comma-separated entry before use, and pass validated entries as direct command arguments using the existing command-building flow; apply the identical implementation in both manifests.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@tkn/infra-aws-ocp-snc.yaml`:
- Around line 288-295: Replace shell-source interpolation and eval-based
operator-channel handling in both tkn/infra-aws-ocp-snc.yaml (lines 288-295) and
tkn/template/infra-aws-ocp-snc.yaml (lines 288-295). Read operator-channel
through an environment variable, validate each comma-separated entry before use,
and pass validated entries as direct command arguments using the existing
command-building flow; apply the identical implementation in both manifests.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e1450f4f-8471-4e70-bffd-6c7cd6405cc7
📒 Files selected for processing (2)
tkn/infra-aws-ocp-snc.yamltkn/template/infra-aws-ocp-snc.yaml
1ddde58 to
29c0567
Compare
…tically Added operator-channel param to infra-aws-ocp-snc task for specifying OLM operator channel overrides (e.g., "operator=channel,operator2=channel2"). Sorted VM type params (cpus, memory, compute-sizes, gpus, gpu-manufacturer, spot params) alphabetically in all AWS Tekton tasks for consistency. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
29c0567 to
327d741
Compare
2 participants
Summary
Exposes the `--operator-channel` CLI flag (added in #806) as a Tekton task param so callers can override OLM subscription channels per operator without rebuilding the image.
Use case: pass `rhods-operator=stable-3.x` to install RHOAI 3.x instead of the default `stable` channel (RHOAI 2.25.x).
Changes
Example
E2E Test Results (2026-07-30) ✅
Validated via RHAIIS-on-RHOAI ITS pipeline run `rhaiis-rhoai-e2e-3x-test6` on OCP 4.21.14:
RHOAI 3.x confirmed by presence of `llminferenceservices` (llmisvc) CRD, which is new in 3.x and absent in 2.25.x. Related: AIPCC-28556, konflux-data MR !447.
🤖 Generated with Claude Code