Skip to content

Conversation

@themr0c
Copy link
Member

@themr0c themr0c commented Nov 28, 2024

  • Change the content about support to a reference module and include in the About title.
  • Remove the current preface about support from all titles.
  • To avoid that the introduction paragraph has the Preface title, use the article document type, rather than book.

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 1.3.x, 1.4.x

Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-5099

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Nov 28, 2024

* Include the support information only once.

Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@themr0c themr0c force-pushed the switch-to-article-and-remove-preface branch from b604df6 to 8f50902 Compare November 28, 2024 10:36
@themr0c themr0c changed the title switch to articles and remove preface Include the support preface content only once in the entire doc set Nov 28, 2024
@themr0c
Copy link
Member Author

themr0c commented Nov 28, 2024

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@themr0c
Copy link
Member Author

themr0c commented Nov 28, 2024

/cherry-pick release-1.4

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Preeticp
Copy link

@themr0c I like the reason why we are doing this, but can we get some reviews from either @Gerry-Forde or @hmanwani-rh as well before we merge this?

@themr0c
Copy link
Member Author

themr0c commented Dec 2, 2024

Discussed in meeting: let's merge

@themr0c themr0c merged commit 601566d into redhat-developer:main Dec 2, 2024
3 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: #750 failed to apply on top of branch "release-1.3":

Applying: * Switch all titles to the `article` document type. * Include the support information only once.
Using index info to reconstruct a base tree...
M	artifacts/attributes.adoc
M	assemblies/assembly-about-rhdh.adoc
M	titles/about/master.adoc
A	titles/install-rhdh-gke/master.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): titles/install-rhdh-gke/master.adoc deleted in HEAD and modified in * Switch all titles to the `article` document type. * Include the support information only once.. Version * Switch all titles to the `article` document type. * Include the support information only once. of titles/install-rhdh-gke/master.adoc left in tree.
Auto-merging titles/about/master.adoc
CONFLICT (content): Merge conflict in titles/about/master.adoc
Auto-merging assemblies/assembly-about-rhdh.adoc
CONFLICT (content): Merge conflict in assemblies/assembly-about-rhdh.adoc
Auto-merging artifacts/attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 * Switch all titles to the `article` document type. * Include the support information only once.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Contributor

@themr0c: new pull request created: #759

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

themr0c added a commit to themr0c/red-hat-developers-documentation-rhdh that referenced this pull request Dec 2, 2024
…#750)

* Include the support information only once.

Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
themr0c added a commit to themr0c/red-hat-developers-documentation-rhdh that referenced this pull request Dec 2, 2024
…#750)

* Include the support information only once.

Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
themr0c added a commit that referenced this pull request Dec 2, 2024
…1.3) (#760)

* * Switch all titles to the `article` document type. (#750)

* Include the support information only once.

Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>

* Delete titles/install-rhdh-gke/master.adoc integrated by mistake

---------

Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@themr0c themr0c deleted the switch-to-article-and-remove-preface branch December 17, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants