fix(lightspeed): stop hardcoding vector_store_ids to product docs only#3626
Merged
rajin-kichannagari merged 2 commits intoJul 13, 2026
Conversation
added 2 commits
June 29, 2026 11:40
The backend plugin was explicitly setting vector_store_ids to only the rhdh-product-docs vector store, which prevented BYOK (Bring Your Own Knowledge) RAG sources from being queried via inline RAG. By removing this override, the lightspeed-stack uses its own rag.inline config to determine which stores to query, enabling multi-source RAG.
rajin-kichannagari
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
June 29, 2026 15:59
Changed Packages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3626 +/- ##
==========================================
+ Coverage 52.89% 52.93% +0.04%
==========================================
Files 2324 2324
Lines 89087 89268 +181
Branches 24900 24999 +99
==========================================
+ Hits 47122 47257 +135
- Misses 41740 41787 +47
+ Partials 225 224 -1
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
JslYoon
reviewed
Jun 29, 2026
JslYoon
left a comment
JslYoon
left a comment
Contributor
There was a problem hiding this comment.
I believe we deliberately disabled rag.inline and only enabled tool.rag because the two conflicted and caused an infinite loop.
Contributor
|
@rajin-kichannagari This PR is still valid and addresses a concern for both BYOK and OKP. I shared some insights on the Slack thread. Maybe we can chat more about this on the Parking Lot or we can discuss on Slack. |
|
maysunfaisal
added a commit
to redhat-developer/rhdh-plugin-export-overlays
that referenced
this pull request
Jul 13, 2026
…ins#3626 Update commit SHA to 6898e78 which includes the fix to stop hardcoding vector_store_ids to product docs only. Co-authored-by: Cursor <cursoragent@cursor.com>
maysunfaisal
added a commit
to redhat-developer/rhdh-plugin-export-overlays
that referenced
this pull request
Jul 13, 2026
…ins#3626 Update commit SHA to 6898e78 which includes the fix to stop hardcoding vector_store_ids to product docs only. Co-authored-by: Cursor <cursoragent@cursor.com>
HusneShabbir
pushed a commit
to HusneShabbir/rhdh-plugins
that referenced
this pull request
Jul 16, 2026
redhat-developer#3626) * fix(lightspeed): stop hardcoding vector_store_ids to product docs only The backend plugin was explicitly setting vector_store_ids to only the rhdh-product-docs vector store, which prevented BYOK (Bring Your Own Knowledge) RAG sources from being queried via inline RAG. By removing this override, the lightspeed-stack uses its own rag.inline config to determine which stores to query, enabling multi-source RAG. * Add changeset for BYOK vector_store_ids fix --------- Co-authored-by: Rajin Kichannagari <rkichann@rkichann-thinkpadp1gen4i.boston.csb>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The backend plugin was explicitly setting
vector_store_idsto only therhdh-product-docsvector store, which prevented BYOK RAG sources configured inrag.inlinefrom being queried via inline RAG.By removing this override, the lightspeed-stack uses its own
rag.inlineconfig to determine which stores to query, enabling multi-source RAG.Context
When BYOK knowledge sources are configured in
lightspeed-stack.yaml, the_fetch_byok_rag()function in lightspeed-stack filters the request'svector_store_idsagainstrag.inline. Since the plugin was only sending the product docs store ID, BYOK stores were always filtered out and inline RAG was silently skipped.✔️ Checklist