fix(orchestrator): Add Workflow Status to WorkflowsTable#564
Conversation
LiorSoffer
requested review from
batzionb,
gciavarrini and
mareklibra
as code owners
Changed Packages
|
There was a problem hiding this comment.
Can this be of any other value then Available and Unavailable?
If not, I would keep that as a boolean and handle the text elsewhere.
There was a problem hiding this comment.
It's originally a boolean, for my understanding this formatter purpose is to costume the data for the user so why do it somewhere else?
There was a problem hiding this comment.
If so, please move the strings into constants, so the decision logic in the WorkflowsTable.tsx will be more stable.
christoph-jerolimov
changed the title
There was a problem hiding this comment.
Can you removed this, please?
There was a problem hiding this comment.
To keep the same code-style, can this be named:
| export const available = 'Available'; | |
| export const AVAILABLE = 'Available'; |
And I keep up to your decision if you prefer to keep it in this file or moving to constants.ts
There was a problem hiding this comment.
ohhh now I understand what "please move the strings into constants" means, which way you prefer?
Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>
|
…ugins into FLPATH-2224 * 'FLPATH-2224' of https://github.com/ijogi-redhat/rhdh-plugins: feat(lightspeed): Adopt road-core service APIs as backend upstream (redhat-developer#516) Version Packages (redhat-developer#606) fix(global-header): remove search bar underline (redhat-developer#603) Version Packages (redhat-developer#563) fix(orchestrator): Add Workflow Status to WorkflowsTable (redhat-developer#564) chore(lightspeed): upgrade PF chatbot in lightspeed (redhat-developer#602) Version Packages (redhat-developer#600) Version Packages (redhat-developer#588) feat(marketplace): removing view plugins button (redhat-developer#599) fix(ai-integrations): improve responsiveness and layout (redhat-developer#596) fix(orchestrator): fix responsiveness of the WorkflowPage (redhat-developer#554) fix(orchestrator): fix view variables screen (redhat-developer#595) feat(ai-experience): Integrate new ai-experience backend plugin (redhat-developer#594)
…loper#564) Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>
2 participants
resolve FLPATH-2201
