Skip to content

fix(ai-integrations): improve responsiveness and layout#596

Merged
karthikjeeyar merged 3 commits into
redhat-developer:mainfrom
Eswaraiahsapram:ai-homepage-fix
Apr 3, 2025
Merged

fix(ai-integrations): improve responsiveness and layout#596
karthikjeeyar merged 3 commits into
redhat-developer:mainfrom
Eswaraiahsapram:ai-homepage-fix

Conversation

@Eswaraiahsapram
Copy link
Copy Markdown
Member

@Eswaraiahsapram Eswaraiahsapram commented Apr 3, 2025

Hey, I just made a Pull Request!

This PR introduces the following changes:

  • Improved responsiveness and layout
  • if display name not available make Guest default
  • added tags component

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented Apr 3, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-ai-experience workspaces/ai-integrations/plugins/ai-experience none v0.1.0

@karthikjeeyar
Copy link
Copy Markdown
Member

karthikjeeyar commented Apr 3, 2025 •
edited
Loading

can we left align this content so that it is consistent with other section content?

image

@Eswaraiahsapram
Copy link
Copy Markdown
Member Author

Eswaraiahsapram commented Apr 3, 2025

can we left align this content so that it is consistent with other section content?

image

@karthikjeeyar it is showing more empty space in right. I guess aligning center makes better

Screenshot 2025-04-03 at 4 24 13 PM

karthikjeeyar
karthikjeeyar approved these changes Apr 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@karthikjeeyar karthikjeeyar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, left aligned looks much better when you compare it with explore AI models section rather than having it in the middle but again these opinions are subjective.

Center aligned Left aligned
image image

I would like see if @ShiranHi has any opinions before I merge this.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Apr 3, 2025
@ShiranHi
Copy link
Copy Markdown

ShiranHi commented Apr 3, 2025

IMHO, left aligned looks much better when you compare it with explore AI models section rather than having it in the middle but again these opinions are subjective.

I agree, left-aligned content is better and easier to read

@openshift-ci openshift-ci Bot removed the lgtm label Apr 3, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

karthikjeeyar
karthikjeeyar approved these changes Apr 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Apr 3, 2025
@karthikjeeyar karthikjeeyar merged commit 393fb40 into redhat-developer:main Apr 3, 2025
9 checks passed
ishanjogi89 added a commit to ishanjogi89/rhdh-plugins that referenced this pull request Apr 7, 2025
@ishanjogi89
Merge branch 'FLPATH-2224' of https://github.com/ijogi-redhat/rhdh-pl…
38f7066 
…ugins into FLPATH-2224

* 'FLPATH-2224' of https://github.com/ijogi-redhat/rhdh-plugins:
  feat(lightspeed): Adopt road-core service APIs as backend upstream  (redhat-developer#516)
  Version Packages (redhat-developer#606)
  fix(global-header): remove search bar underline (redhat-developer#603)
  Version Packages (redhat-developer#563)
  fix(orchestrator): Add Workflow Status to WorkflowsTable (redhat-developer#564)
  chore(lightspeed): upgrade PF chatbot in lightspeed (redhat-developer#602)
  Version Packages (redhat-developer#600)
  Version Packages (redhat-developer#588)
  feat(marketplace): removing view plugins button (redhat-developer#599)
  fix(ai-integrations): improve responsiveness and layout (redhat-developer#596)
  fix(orchestrator): fix responsiveness of the WorkflowPage (redhat-developer#554)
  fix(orchestrator): fix view variables screen (redhat-developer#595)
  feat(ai-experience): Integrate new ai-experience backend plugin (redhat-developer#594)
elai-shalev pushed a commit to elai-shalev/rhdh-plugins that referenced this pull request Jan 21, 2026
@Eswaraiahsapram
fix(ai-integrations): improve responsiveness and layout (redhat-devel…
1bbbe84 
…oper#596)

* fix(ai-integrations): improve responsiveness and layout

* fix(ai-integrations): improve responsiveness and layout

* addressed review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthikjeeyar karthikjeeyar karthikjeeyar approved these changes

@johnmcollier johnmcollier Awaiting requested review from johnmcollier johnmcollier is a code owner

@gabemontero gabemontero Awaiting requested review from gabemontero gabemontero is a code owner

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03 rohitkrai03 is a code owner

Assignees

@karthikjeeyar karthikjeeyar

Labels

lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Eswaraiahsapram @karthikjeeyar @ShiranHi