feat: add rhdh-coding skill for Backstage/RHDH plugin development#51
feat: add rhdh-coding skill for Backstage/RHDH plugin development#51rohitkrai03 wants to merge 1 commit into
Conversation
d1c0072 to
dc7d874
Compare
6b9bc67 to
8bcf227
Compare
Adds a coding skill that teaches agents non-obvious Backstage and RHDH patterns — the knowledge you'd gain after six months of getting burned by conventions that aren't in the docs or training data. Covers: BUI-first styling, NFS Blueprints, RHDH dynamic plugin gotchas, plugin type decisions, Backstage-specific testing, dev app setup (both plugin dev mode and full Backstage app), and frontend spec guidance for PRDs/OpenSpec workflows. References are verified against real plugin code in rhdh-plugins and community-plugins. Designed to be the daily-driver skill for agents working on existing plugins — complementary to create-plugin (new plugins), nfs-migration (migration), and official backstage.io skills. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rohit Rai <rohitkrai03@gmail.com>
8bcf227 to
4e71e88
Compare
durandom
left a comment
There was a problem hiding this comment.
Review
Comprehensive skill capturing Backstage/RHDH plugin development tribal knowledge. This is the kind of content that saves developers hours of debugging.
What's good
- BUI reference (`bui.md`) — the component mapping table (BUI ↔ MUI) with key API differences is exactly what's needed for migration. Calling out `Card`'s discriminated union, `Select`'s onChange signature, and `Table`'s `isRowHeader` requirement prevents real bugs.
- NFS patterns (`nfs.md`) — alpha file structure, PageBlueprint/EntityContentBlueprint patterns, and the package exports section (NFS-at-root vs legacy-at-root vs alpha pattern) addresses a genuine source of confusion.
- Testing reference (`testing.md`) — TestApiProvider patterns, entity context mocking approaches (EntityProvider vs jest.mock), MSW setup, and the SWR cache reset trick are all verified patterns from real plugins.
- Detection script — stdlib-only Python, clean structure, covers all the right signals (backstage role, frontend system, MUI version, extensions, blueprints, route refs, API refs, dynamic plugin status).
- "Before You Commit" checklist — the ordered sequence (`prettier:fix` → `tsc:full` → `build:all` → `test` → `build:api-reports:only`) with "stop on first failure" is practical.
Issues
-
Merge conflicts — this PR has conflicts with main and no CI runs. Needs a rebase before it can be reviewed for merge readiness.
-
Version bump assumes #49 merged. The diff shows 0.6.0 → 0.7.0, meaning this is based on PR #49's branch. If #49 hasn't merged, this can't either. Clarify the dependency chain.
-
`references/bui.md` caveat. The skill says "Always check `node_modules/@backstage/ui/dist/index.d.ts` for actual prop types" — good. But the BUI component list will go stale as BUI evolves. Consider adding a date or BUI version at the top so readers know when it was last verified.
-
`references/nfs.md` — NavItemBlueprint removal note. "NavItemBlueprint was removed" — this is correct for latest Backstage but worth noting which version this changed in, since plugins targeting older RHDH versions may still need it.
-
Ecosystem skills section. Recommending `npx skills add` for third-party skills is useful, but these URLs/repos could go stale. Consider moving this to a separate reference file that's easier to update.
Recommendation
Excellent content. Blocked on rebase (conflicts) and the #49 dependency. Once those are resolved, this is merge-ready.
Why
RHDH is moving toward an agentic SDLC with fullsend — agents triage issues, implement features, and review code autonomously. The coding agent needs Backstage/RHDH patterns that aren't in training data (BUI is new, NFS is evolving, dynamic plugin conventions are tribal knowledge). No Backstage coding skills exist in the open-source ecosystem — the official backstage.io skills cover migrations and instrumentation, not day-to-day feature development.
This skill fills that gap. It's the daily-driver skill for agents working on RHDH plugins — installed into
.fullsend/customized/skills/alongsiderhdh-workspaceand available to the code agent during implementation. It also helps human developers using Claude Code, Cursor, or any skills-compatible agent.What it covers
How it fits into fullsend
Complements ecosystem skills (ui-ux-pro-max, frontend-design, webapp-testing) for generic UI quality, and official backstage.io skills for migration workflows.
Summary
Files
SKILL.mdreferences/bui.mdreferences/dev-app.mdreferences/nfs.mdreferences/frontend-specs.mdreferences/plugin-types.mdreferences/rhdh.mdreferences/testing.mdscripts/detect-rhdh-context.pyTest plan
npx skills addand verify skill triggers correctly🤖 Generated with Claude Code