Skip to content

chore(e2e): skip audit log test - #2231

Merged
openshift-merge-bot[bot] merged 2 commits into
redhat-developer:mainfrom
subhashkhileri:skip-audit-log-test
Jan 22, 2025
Merged

chore(e2e): skip audit log test#2231
openshift-merge-bot[bot] merged 2 commits into
redhat-developer:mainfrom
subhashkhileri:skip-audit-log-test

Conversation

@subhashkhileri

Copy link
Copy Markdown
Member

Description

skip audit log test until its fixed.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci
openshift-ci Bot requested a review from gustavolira January 22, 2025 08:23
@openshift-ci
openshift-ci Bot requested a review from psrna January 22, 2025 08:23

@christoph-jerolimov christoph-jerolimov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

We have issue https://issues.redhat.com/browse/RHIDP-5634 to fix that.

@christoph-jerolimov

Copy link
Copy Markdown
Member

@subhashkhileri can you check why the Node.js job failed?

/lgtm

@openshift-ci openshift-ci Bot removed the lgtm label Jan 22, 2025
@zdrapela

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci

openshift-ci Bot commented Jan 22, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christoph-jerolimov, zdrapela

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 1949c08 into redhat-developer:main Jan 22, 2025
chadcrum pushed a commit to chadcrum/rhdh that referenced this pull request Aug 3, 2025
gustavolira added a commit to gustavolira/rhdh that referenced this pull request Jul 7, 2026
…veloper#2714/redhat-developer#2731)

The companion analysis recommended rebuilding PR redhat-developer#2231's in-process idea on
the published CLI — that landed in the overlay repo on 2026-07-06/07 as
smoke-tests-native (overlays#2714, ~20x vs the Docker smoke) plus workspace
mode (overlays#2731), running as a dedicated native-smoke.yaml workflow
alongside the Docker one. Mark recommendation 1 as landed and add both PRs
to References.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gustavolira added a commit to gustavolira/rhdh that referenced this pull request Jul 20, 2026
…veloper#2714/redhat-developer#2731)

The companion analysis recommended rebuilding PR redhat-developer#2231's in-process idea on
the published CLI — that landed in the overlay repo on 2026-07-06/07 as
smoke-tests-native (overlays#2714, ~20x vs the Docker smoke) plus workspace
mode (overlays#2731), running as a dedicated native-smoke.yaml workflow
alongside the Docker one. Mark recommendation 1 as landed and add both PRs
to References.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
openshift-merge-bot Bot pushed a commit that referenced this pull request Jul 20, 2026
* docs(e2e): add E2E layer migration matrix (RHIDP-15076)

Phase-1 deliverable of RHIDP-15076 (E2E Test Optimization epic
RHIDP-13501): classifies all 30 e2e specs by target layer (L1-L4b),
maps which are supplementable by Layer 3 component tests or the
cluster-free L4a harness, and includes the companion analysis of the
rhdh-plugin-export-overlays test system. Referenced from the Jira
story's closing comment; updated 2026-07-02 with the L4a harness
validation results from PR #5005 (4 tests green cluster-free).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(e2e): address review — reconcile counts, durable references, README link

- Fix the Tally L3 count (10, not 9) so the column totals sum to the
  30-spec heading; reconcile the heading itself (29 on main + #19 pending
  in PR #4967).
- "runs 4 tests" -> "runs 2 specs (4 test cases)" — the doc's accounting
  unit is the spec; note that spec numbers refer to the matrix below.
- Soften "fully covers the 12 pure-backend workspaces" to load + API
  surface: scaffolder-backend-module-kubernetes also has a UI e2e that
  needs the render harness, so "fully" overstated the native-smoke scope.
- Replace short commit hashes and the fork-only
  RHIDP-13235-layer3-component-tests branch name with the durable PR
  reference (rhdh#4864, closed) — hashes on a mutable branch dangle after
  a rebase or branch deletion.
- Give DRAFT a promotion condition (groomed into RHIDP-13528/13529).
- Link the matrix from docs/e2e-tests/README.md ("Adding a Test") so the
  doc is discoverable outside the Jira comment.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(e2e): correct licensed-users-info blocker — internal backend plugin, not OCI

* docs(e2e): address review — fix spec count, dangling reference, dated wording

- 2026-07-07 update: 10 specs (not 9) — the list itself names ten files.
- Drop the positional "queue above" reference (the queue list no longer
  precedes it) and past-tense the 2026-07-02 "now runs" so the two dated
  updates stop contradicting each other.
- Self-date the PR #4967 "open" claim and add PR #5057 to References.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(e2e): record the merged overlays native smoke harness (#2714/#2731)

The companion analysis recommended rebuilding PR #2231's in-process idea on
the published CLI — that landed in the overlay repo on 2026-07-06/07 as
smoke-tests-native (overlays#2714, ~20x vs the Docker smoke) plus workspace
mode (overlays#2731), running as a dedicated native-smoke.yaml workflow
alongside the Docker one. Mark recommendation 1 as landed and add both PRs
to References.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(e2e): address review — reconcile landed-vs-target claims and stale count

- "Every remaining candidate landed" contradicted the #2 bullet in the same
  section — now "every candidate except #2".
- The native-harness recommendation read as if the full Docker-smoke
  replacement had shipped; scope it to what overlays#2714 landed (backend
  boots), with catalog-extending modules and the frontend bundle probe
  still pending (same qualifier in the bucket table).
- ROI paragraph still said 9 L3 candidates after the tally fix made it 10.
- Date-mark the pre-#2714 two-tier takeaway so it points at the update.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(e2e): correct #4864 status and refresh matrix against main

Re-verified the document against origin/main (2026-07-20):

- rhdh#4864 was **merged** on 2026-06-01, not "closed, not merged". The six
  Layer 3 tests are on main under packages/app/src — replace the prose
  descriptions with the actual file paths so the reference stays durable.
- Batch 1 no longer asks to "close out" #5/#6/#8/#9; that work landed.
- #18 github-happy-path is no longer a showcase `.fixme`; #5022 parked it at
  e2e-tests/playwright/blocked/github-happy-path.blocked.ts.
- Spell out how the "29 specs on main" count is composed (28 *.spec.ts + the
  blocked one) so it can be re-checked mechanically.
- Refresh dates; #4967 is still open as of 2026-07-20.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants