Skip to content

chore: [release-1.9] create separate layer for techdocs dependencies …#4553

Merged
openshift-merge-bot[bot] merged 2 commits intoredhat-developer:release-1.9from
Omar-AlJaljuli:RHIDP-11298-1.9
Apr 8, 2026
Merged

chore: [release-1.9] create separate layer for techdocs dependencies …#4553
openshift-merge-bot[bot] merged 2 commits intoredhat-developer:release-1.9from
Omar-AlJaljuli:RHIDP-11298-1.9

Conversation

@Omar-AlJaljuli
Copy link
Copy Markdown
Contributor

…and venv creation

Description

I moved the techdocs dependencies installations from the final layer in the runner image to a new techdocs layer created. This is a cleaner implementation of brute forcing the deletion of the packages at the final layer, also slightly furthers decreasing the image size.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci Bot requested review from davidfestal and rm3l April 8, 2026 16:48
@Omar-AlJaljuli Omar-AlJaljuli changed the title chore: [release-1.9] create separate layer for techdocs dependencies … chore: [release-1.9] create separate layer for techdocs dependencies … Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

The container image build workflow finished with status: cancelled.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 8, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Image was built and published successfully. It is available at:

Copy link
Copy Markdown
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as on #4551

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Apr 8, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 6d050a1 into redhat-developer:release-1.9 Apr 8, 2026
14 checks passed
@Omar-AlJaljuli Omar-AlJaljuli deleted the RHIDP-11298-1.9 branch April 8, 2026 19:45
polasudo added a commit to polasudo/rhdh that referenced this pull request Apr 23, 2026
PR redhat-developer#4553 moved the techdocs-venv creation from the build stage into
the cleanup stage, but the COPY instruction in the runner stage still
referenced --from=build. This caused every image build on release-1.9
to fail since April 8 with:
  "failed to calculate checksum of ref: /opt/techdocs-venv: not found"

Since next-* tags have a 14-day Quay expiration (quay.expires-after=14d),
the last successful next-1.9 image (built April 7) expired on April 21,
breaking smoke tests in the overlay repo.

The fix moves the techdocs-venv RUN block back into the build stage
(matching release-1.8 and main), where the python3.11 and pip
dependencies from the skeleton base image are available. The
COPY --from=build in the runner stage now correctly finds the venv.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants