fix: copy techdocs-venv from cleanup stage in Dockerfile#4682
fix: copy techdocs-venv from cleanup stage in Dockerfile#4682polasudo wants to merge 2 commits intoredhat-developer:release-1.9from
Conversation
PR redhat-developer#4553 moved the techdocs-venv creation from the build stage into the cleanup stage, but the COPY instruction in the runner stage still referenced --from=build. This caused every image build on release-1.9 to fail since April 8 with: "failed to calculate checksum of ref: /opt/techdocs-venv: not found" Since next-* tags have a 14-day Quay expiration (quay.expires-after=14d), the last successful next-1.9 image (built April 7) expired on April 21, breaking smoke tests in the overlay repo. The fix changes COPY --from=build to COPY --from=cleanup to match where the techdocs-venv is actually built, consistent with how release-1.8 handles this (where the venv is built in the build stage and correctly copied from there). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
I'd move https://github.com/redhat-developer/rhdh/blob/release-1.9/docker/Dockerfile#L205-L214 to the build stage instead. I believe that there were dependencies there that the techdocs-venv relied on as well to build. |
PR redhat-developer#4553 moved the techdocs-venv creation from the build stage into the cleanup stage, but the COPY instruction in the runner stage still referenced --from=build. This caused every image build on release-1.9 to fail since April 8 with: "failed to calculate checksum of ref: /opt/techdocs-venv: not found" Since next-* tags have a 14-day Quay expiration (quay.expires-after=14d), the last successful next-1.9 image (built April 7) expired on April 21, breaking smoke tests in the overlay repo. The fix moves the techdocs-venv RUN block back into the build stage (matching release-1.8 and main), where the python3.11 and pip dependencies from the skeleton base image are available. The COPY --from=build in the runner stage now correctly finds the venv. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
@polasudo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
next-1.9image builds caused by movingtechdocs-venvcreation from thebuildstage to thecleanupstage, but left theCOPY --from=buildinstruction unchanged in therunnerstagerelease-1.9has been failing since April 8 with:failed to calculate checksum of ref: "/opt/techdocs-venv": not foundnext-1.9Quay tag expired on April 21 (14-day TTL viaquay.expires-after=14d), breaking smoke tests in the overlay repoRoot Cause
moved the techdocs-venv
RUNblock into the cleanup stage (afterFROM skeleton AS cleanupat line 157), but line 242 still had:COPY --from=build --chown=1001:1001 /opt/techdocs-venv /opt/techdocs-venvSince the venv is built in
cleanup, notbuild, theCOPYfails. For comparison,release-1.8builds the venv inside thebuildstage so itsCOPY --from=buildworks correctly.Fix
Changed line 242 from
COPY --from=buildtoCOPY --from=cleanupto match where the venv is actually created:COPY --from=cleanup --chown=1001:1001 /opt/techdocs-venv /opt/techdocs-venvTest plan
next-build-imageworkflow succeeds on this branchnext-1.9tag reappears inquay.io/rhdh-community/rhdhrhdh:next-1.9🤖 Generated with Claude Code